Re: [PATCH] ALSA: ak4114: remove redundant check on err being < 0

From	Takashi Iwai <tiwai@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ALSA: ak4114: remove redundant check on err being < 0
Date	2016-07-12 12:40 +0200
Message-ID	<rU3gB-3DR-5@gated-at.bofh.it> (permalink)
References	<rU36V-3AD-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 12 Jul 2016 12:26:29 +0200,
Colin King wrote:
> 
> From: Colin Ian King <colin.king@canonical.com>
> 
> snd_ak4114_create checks if the error return err is less than zero
> or not.  This is a redundant check, err can only be < 0 to get to
> the __fail label, in which case just return err and remove the
> redundant check (since we never return -EIO).
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied, thanks.


Takashi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ALSA: ak4114: remove redundant check on err being < 0 Colin King <colin.king@canonical.com> - 2016-07-12 12:30 +0200
  Re: [PATCH] ALSA: ak4114: remove redundant check on err being < 0 Takashi Iwai <tiwai@suse.de> - 2016-07-12 12:40 +0200

csiph-web