Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1440220

[PATCH] xen_pvscsi: reclaim the ring request when mapping data failed

Show all headers | View raw

During scsi command queueing, if mapping data fails, we need to
reclaim the failed request. Otherwise, the garbage request will
be pushed into the ring for the backend to work.

Signed-off-by: Bin Wu <wu.wubin@huawei.com>
---
  drivers/scsi/xen-scsifront.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c
index 9dc8687..655163d 100644
--- a/drivers/scsi/xen-scsifront.c
+++ b/drivers/scsi/xen-scsifront.c
@@ -565,6 +565,7 @@ static int scsifront_queuecommand(struct Scsi_Host *shost,
      err = map_data_for_request(info, sc, ring_req, shadow);
      if (err < 0) {
          pr_debug("%s: err %d\n", __func__, err);
+        info->ring.req_prod_pvt--;
          scsifront_put_rqid(info, rqid);
          scsifront_return(info);
          spin_unlock_irqrestore(shost->host_lock, flags);
-- 
2.3.2 (Apple Git-55)

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] xen_pvscsi: reclaim the ring request when mapping data failed Bin Wu <wu.wubin@huawei.com> - 2016-07-11 05:00 +0200
  Re: [PATCH] xen_pvscsi: reclaim the ring request when mapping data  failed Juergen Gross <jgross@suse.com> - 2016-07-11 11:40 +0200
    Re: [Xen-devel] [PATCH] xen_pvscsi: reclaim the ring request when  mapping data failed Juergen Gross <jgross@suse.com> - 2016-07-11 12:00 +0200
      Re: [Xen-devel] [PATCH] xen_pvscsi: reclaim the ring request when  mapping data failed Bin Wu <wu.wubin@huawei.com> - 2016-07-12 02:40 +0200
    Re: [Xen-devel] [PATCH] xen_pvscsi: reclaim the ring request when  mapping data failed David Vrabel <david.vrabel@citrix.com> - 2016-07-11 12:00 +0200

csiph-web