Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1440171
| From | Alison Schofield <amsfield22@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 2/2] iio: humidity: hdc100x: remove lock on heater configuration read |
| Date | 2016-07-10 23:40 +0200 |
| Message-ID | <rTuCd-6ic-3@gated-at.bofh.it> (permalink) |
| References | <rTusx-6e3-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
The lock around the read (from global data) of the heater configuration
status is not needed. Move the lock in IIO_CHAN_INFO_RAW case to only
protect the get measurement function.
Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Cc: Daniel Baluta <daniel.baluta@gmail.com>
---
drivers/iio/humidity/hdc100x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c
index ad5a12a..8195b0c 100644
--- a/drivers/iio/humidity/hdc100x.c
+++ b/drivers/iio/humidity/hdc100x.c
@@ -193,18 +193,18 @@ static int hdc100x_read_raw(struct iio_dev *indio_dev,
case IIO_CHAN_INFO_RAW: {
int ret;
- mutex_lock(&data->lock);
if (chan->type == IIO_CURRENT) {
*val = hdc100x_get_heater_status(data);
ret = IIO_VAL_INT;
} else {
+ mutex_lock(&data->lock);
ret = hdc100x_get_measurement(data, chan);
+ mutex_unlock(&data->lock);
if (ret >= 0) {
*val = ret;
ret = IIO_VAL_INT;
}
}
- mutex_unlock(&data->lock);
return ret;
}
case IIO_CHAN_INFO_INT_TIME:
--
2.1.4
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/2] iio: humidity: hdc100x: update driver locking Alison Schofield <amsfield22@gmail.com> - 2016-07-10 23:30 +0200
[PATCH 2/2] iio: humidity: hdc100x: remove lock on heater configuration read Alison Schofield <amsfield22@gmail.com> - 2016-07-10 23:40 +0200
[PATCH 1/2] iio: humidity: hdc100x: move lock on config updates to single function Alison Schofield <amsfield22@gmail.com> - 2016-07-10 23:40 +0200
Re: [PATCH 1/2] iio: humidity: hdc100x: move lock on config updates to single function Alison Schofield <amsfield22@gmail.com> - 2016-07-16 07:30 +0200
csiph-web