Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1440126

Re: [PATCH 0/5] hwmon: New hwmon registration API

Show all headers | View raw

On 26/06/16 04:26, Guenter Roeck wrote:
> Up to now, each hwmon driver has to implement its own sysfs attributes.
> This requires a lot of template code, and distracts from the driver's
> core function to read and write chip registers.
> 
> To be able to reduce driver complexity, move sensor attribute handling
> and thermal zone registration into the hwmon core. By using the new API,
> driver size is typically reduced by 20-50% depending on driver complexity
> and the number of sysfs attributes supported.
> 
> The first patch of the series introduces the API as well as support
> for temperature sensors. Subsequent patches introduce support for
> voltage, current, power, energy, humidity, and fan speed sensors.
> 
> The series was tested by converting several drivers (lm75, lm90, tmp102,
> tmp421, ltc4245) to the new API. Testing was done with with real chips
> as well as with the hwmon driver module test code available at
> https://github.com/groeck/module-tests.
Some cool stuff hiding in there :)

I've only reviewed 1 and 7 and the intermediate ones are really either
correct or they aren't and they look fine to me.


So what's next? (beyond presumably a lot of driver conversions).

Jonathan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] hwmon: New hwmon registration API Guenter Roeck <linux@roeck-us.net> - 2016-06-26 05:30 +0200
  [PATCH 6/7] hwmon: (core) Add fan attribute support to new API Guenter Roeck <linux@roeck-us.net> - 2016-06-26 05:30 +0200
  [PATCH 7/7] hwmon: (core) Document new kernel API Guenter Roeck <linux@roeck-us.net> - 2016-06-26 05:30 +0200
    Re: [PATCH 7/7] hwmon: (core) Document new kernel API Jonathan Cameron <jic23@kernel.org> - 2016-07-10 18:00 +0200
  [PATCH 5/7] hwmon: (core) Add energy and humidity attribute support to new API Guenter Roeck <linux@roeck-us.net> - 2016-06-26 05:30 +0200
  Re: [PATCH 0/5] hwmon: New hwmon registration API Punit Agrawal <punit.agrawal@arm.com> - 2016-07-08 11:40 +0200
    Re: [PATCH 0/5] hwmon: New hwmon registration API Guenter Roeck <linux@roeck-us.net> - 2016-07-08 15:50 +0200
  Re: [PATCH 0/5] hwmon: New hwmon registration API Jonathan Cameron <jic23@kernel.org> - 2016-07-10 18:10 +0200
    Re: [PATCH 0/5] hwmon: New hwmon registration API Guenter Roeck <linux@roeck-us.net> - 2016-07-11 03:00 +0200
      Re: [PATCH 0/5] hwmon: New hwmon registration API Jonathan Cameron <jic23@kernel.org> - 2016-07-20 17:20 +0200
        Re: [PATCH 0/5] hwmon: New hwmon registration API Guenter Roeck <linux@roeck-us.net> - 2016-07-20 20:40 +0200

csiph-web