RE: Hi, Ingo, would you please help drop the TSC MSR calibration patch

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	"Chen, Yu C" <yu.c.chen@intel.com>
Newsgroups	linux.kernel
Subject	RE: Hi, Ingo, would you please help drop the TSC MSR calibration patch
Date	Tue, 12 Jul 2016 03:00:02 +0200
Message-ID	<rTUdk-63m-7@gated-at.bofh.it> (permalink)
References	<rTLtn-rG-21@gated-at.bofh.it> <rTLtn-rG-19@gated-at.bofh.it> <rTPdE-2Wt-13@gated-at.bofh.it> <rTQW6-453-11@gated-at.bofh.it>
X-Original-To	"Pan, Jacob jun" <jacob.jun.pan@intel.com>, Ingo Molnar <mingo@kernel.org>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.28,348,1464678000"; d="scan'208";a="137542417"
Thread-Topic	Hi, Ingo, would you please help drop the TSC MSR calibration patch
Thread-Index	AQHR24pJ32w7o8pQOU+UwPcKCV3SbaATGFUAgAAeCICAALFrUA==
Accept-Language	en-US
Content-Language	en-US
X-Titus-Metadata-40	eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTJiY2JkNTEtZThiNy00NGMzLThkODMtYjlkZDk0YTk0YjI1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Im5OcWVObmFEcDBIekhcLzFFTWJVbkQ5N1VqSFRKY1wvT1ZiYVFwNm9MMXpOND0ifQ==
X-Ctpclassification	CTP_IC
X-Originating-IP	[10.239.127.40]
Content-Type	text/plain; charset="us-ascii"
Content-Transfer-Encoding	8BIT
MIME-Version	1.0
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	64
Organization	linux.* mail to news gateway
X-Original-Cc	'Len Brown' <lenb@kernel.org>, Jacob Pan <jacob.jun.pan@linux.intel.com>, "H. Peter Anvin" <hpa@zytor.com>, Peter Zijlstra <peterz@infradead.org>, "x86@kernel.org" <x86@kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
X-Original-Date	Tue, 12 Jul 2016 00:57:38 +0000
X-Original-Message-ID	<36DF59CE26D8EE47B0655C516E9CE64028780331@shsmsx102.ccr.corp.intel.com>
X-Original-References	<36DF59CE26D8EE47B0655C516E9CE6402878009C@shsmsx102.ccr.corp.intel.com> <20160711083540.02f86b3f@icelake> <20160711193103.GA27007@gmail.com> <20160711141833.352e16e3@icelake>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1440996

Show key headers only | View raw

Hi, 
> -----Original Message-----
> From: Pan, Jacob jun
> Sent: Tuesday, July 12, 2016 5:19 AM
> To: Ingo Molnar
> Cc: Chen, Yu C; 'Len Brown'; Jacob Pan; H. Peter Anvin; Peter Zijlstra;
> x86@kernel.org; linux-kernel@vger.kernel.org; Pan, Jacob jun
> Subject: Re: Hi, Ingo, would you please help drop the TSC MSR calibration patch
> 
> On Mon, 11 Jul 2016 21:31:04 +0200
> Ingo Molnar <mingo@kernel.org> wrote:
> 
> >
> > * Jacob Pan <jacob.jun.pan@intel.com> wrote:
> >
> > > On Mon, 11 Jul 2016 07:59:19 -0700
> > > "Chen, Yu C" <yu.c.chen@intel.com> wrote:
> > >
> > > > Currently it is in your x86/timer tree:
> > > >
> > > > commit fc273eeef314cdaf0ac992b400d126f8184a4d1c
> > > > Author: Len Brown <len.brown@intel.com>
> > > > Date:   Fri Jun 17 01:22:49 2016 -0400
> > > >
> > > >     x86/tsc_msr: Extend to include Intel Core Architecture
> > > >
> > > >
> > > > Previously we found this patch might decrease the performance on
> > > > one of our servers, due to the small gap between using old PIT
> > > > calibration and new MSR calibration method, so we currently would
> > > > like to hold this patch for now, until we got a clear answer from
> > > > our architect. Would you please help revert this patch (the other
> > > > patches are safe and can be merged), sorry for the inconvenience.
> > > >
> > > I modified the subject slightly to be more specific.
> > > Adding lkml and x86 list, and a few more people.
> > > This commit is also affected, won't compile if we revert the one
> > > above.
> > >
> > > 37c528e... x86/tsc_msr: Fix rdmsr(MSR_PLATFORM_INFO) unsafe warning
> > > in KVM guest
> >
> > Ok, I've rebased tip:x86/timers, it now includes the following
> > commits:
> >
> > ff4c86635ee1 x86/tsc: Enumerate BXT tsc_khz via CPUID
> > aa297292d708 x86/tsc: Enumerate SKL cpu_khz and tsc_khz via CPUID
> > 02c0cd2dcf7f x86/tsc_msr: Remove irqoff around MSR-based TSC
> > enumeration 6fcb41cdaee5 x86/tsc_msr: Add Airmont reference clock
> > values 05680e7fa8a4 x86/tsc_msr: Correct Silvermont reference clock
> > values 9e0cae9f6227 x86/tsc_msr: Update comments, expand definitions
> > 14bb4e34860a x86/tsc_msr: Remove debugging messages
> > ba8268330dc1 x86/tsc_msr: Identify Intel-specific code
> > fc5f3ac24720 Revert "x86/tsc: Add missing Cherrytrail frequency to the
> > table"
> >
> > Does that work for you?
> >
> works for me but Yu has to confirm.
> 
Confirmed, thanks!

thanks,
Yu

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: Hi, Ingo, would you please help drop the TSC MSR calibration  patch Jacob Pan <jacob.jun.pan@intel.com> - 2016-07-11 17:40 +0200
  Re: Hi, Ingo, would you please help drop the TSC MSR calibration  patch Ingo Molnar <mingo@kernel.org> - 2016-07-11 21:40 +0200
    Re: Hi, Ingo, would you please help drop the TSC MSR calibration  patch Jacob Pan <jacob.jun.pan@intel.com> - 2016-07-11 23:30 +0200
      RE: Hi, Ingo, would you please help drop the TSC MSR calibration  patch "Chen, Yu C" <yu.c.chen@intel.com> - 2016-07-12 03:00 +0200

csiph-web