Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1441018

Re: [PATCH 23/27] HID: wacom: leds: use the ledclass instead of custom made sysfs files

Show all headers | View raw

On Tue, Jul 05, 2016 at 04:39:19PM +0200, Benjamin Tissoires wrote:
> The now obsolete sysfs files for LEDs and EKRemote are kept for backward
> compatibility.
> Both the EKR (read-only) and the regular Cintiqs and Intuos are now
> sharing the same led API.
> 
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> ---
>  Documentation/ABI/testing/sysfs-driver-wacom |   5 +
>  drivers/hid/wacom.h                          |  19 +++
>  drivers/hid/wacom_sys.c                      | 191 +++++++++++++++++++++++++--
>  3 files changed, 205 insertions(+), 10 deletions(-)
> 
[...]

> +static int wacom_led_register_one(struct device *dev, struct wacom *wacom,
> +				  struct wacom_led *led, unsigned int group,
> +				  unsigned int id, bool read_only)
> +{
> +	int error;
> +	char *name;
> +
> +	name = devm_kasprintf(dev, GFP_KERNEL,
> +			      "%s::wacom-led_%d.%d",
> +			      dev_name(dev),
> +			      group,
> +			      id);

let's use something other than the - and _ mix please. I'd prefer
wacom-led-0.1 but I'll also accept wacom_led_0.1, the mix is a bit of an
eyesore.

also, arguably you don't need the "led" bit, see e.g.  "input3::capslock" so
even "input123::wacom-0.1" would be ok too.

Cheers,
   Peter

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 23/27] HID: wacom: leds: use the ledclass instead of  custom made sysfs files Peter Hutterer <peter.hutterer@who-t.net> - 2016-07-12 03:50 +0200

csiph-web