Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1440985
| From | Bin Wu <wu.wubin@huawei.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2] xen_pvscsi: reclaim the ring request when the prepairing failed |
| Date | 2016-07-12 02:40 +0200 |
| Message-ID | <rTTTX-5WU-5@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
During scsi command queueing or exception handling, if prepairing fails, we need to reclaim the failed request. Otherwise, the garbage request will be pushed into the ring for the backend to work. Signed-off-by: Bin Wu <wu.wubin@huawei.com> --- drivers/scsi/xen-scsifront.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c index 9dc8687..8646db1 100644 --- a/drivers/scsi/xen-scsifront.c +++ b/drivers/scsi/xen-scsifront.c @@ -184,8 +184,6 @@ static struct vscsiif_request *scsifront_pre_req(struct vscsifrnt_info *info) ring_req = RING_GET_REQUEST(&(info->ring), ring->req_prod_pvt); - ring->req_prod_pvt++; - ring_req->rqid = (uint16_t)id; return ring_req; @@ -196,6 +194,8 @@ static void scsifront_do_request(struct vscsifrnt_info *info) struct vscsiif_front_ring *ring = &(info->ring); int notify; + ring->req_prod_pvt++; + RING_PUSH_REQUESTS_AND_CHECK_NOTIFY(ring, notify); if (notify) notify_remote_via_irq(info->irq); -- 2.3.2 (Apple Git-55)
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH v2] xen_pvscsi: reclaim the ring request when the prepairing failed Bin Wu <wu.wubin@huawei.com> - 2016-07-12 02:40 +0200 Re: [PATCH v2] xen_pvscsi: reclaim the ring request when the prepairing failed Juergen Gross <jgross@suse.com> - 2016-07-12 10:10 +0200
csiph-web