Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1440956

Re: [PATCH 1/3] regulator: qcom_smd: Fix voltage ranges for pm8x41

Show all headers | View raw

On Mon, Jul 11, 2016 at 02:50:07PM -0700, Stephen Boyd wrote:
> The voltage ranges listed here are wrong. The correct ranges can
> be seen in the "native" spmi regulator driver
> qcom_spmi-regulator.c at pldo_ranges[], ftsmps_ranges[] and
> boost_ranges[] for the pldo, ftsmps, and boost type regulators.
> Port these ranges over to the RPM SMD regulator driver so that we
> list the appropriate set of supported voltages on pldos.
> 
> Doing this allows us to specify a voltage like 3075000 for l24,
> whereas before that wasn't a supported voltage.
> 
> Cc: Andy Gross <andy.gross@linaro.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Fixes: da65e367b67e ("regulator: Regulator driver for the Qualcomm RPM")
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---

<snip>

>  static const struct regulator_desc pm8941_pldo = {
>  	.linear_ranges = (struct regulator_linear_range[]) {
> -		REGULATOR_LINEAR_RANGE( 750000,  0,  30, 25000),
> -		REGULATOR_LINEAR_RANGE(1500000, 31, 99, 50000),
> +		REGULATOR_LINEAR_RANGE( 750000,  0,  63, 12500),
> +		REGULATOR_LINEAR_RANGE(1550000, 64, 126, 25000),
> +		REGULATOR_LINEAR_RANGE(3100000, 127, 163, 50000),
>  	},
> -	.n_linear_ranges = 2,
> -	.n_voltages = 100,
> +	.n_linear_ranges = 3,
> +	.n_voltages = 164,
>  	.ops = &rpm_smps_ldo_ops,
>  };

Still a little confused on if the 12.5mV is allowed on pmos ldo.  It seems like the
nmos has 1 range of 5mV steps.  The PMOS has 2 ranges, using 25mV and 50mV


Regards,

Andy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] Fixes for RPM SMD regulator voltage ranges Stephen Boyd <sboyd@codeaurora.org> - 2016-07-12 00:00 +0200
  [PATCH 1/3] regulator: qcom_smd: Fix voltage ranges for pm8x41 Stephen Boyd <sboyd@codeaurora.org> - 2016-07-12 00:00 +0200
    Re: [PATCH 1/3] regulator: qcom_smd: Fix voltage ranges for pm8x41 Andy Gross <andy.gross@linaro.org> - 2016-07-12 00:50 +0200
  [PATCH 3/3] regulator: qcom_smd: Avoid overlapping linear voltage ranges Stephen Boyd <sboyd@codeaurora.org> - 2016-07-12 00:00 +0200
    Re: [PATCH 3/3] regulator: qcom_smd: Avoid overlapping linear  voltage ranges Andy Gross <andy.gross@linaro.org> - 2016-07-12 00:50 +0200
    Applied "regulator: qcom_smd: Avoid overlapping linear voltage ranges" to the regulator tree Mark Brown <broonie@kernel.org> - 2016-07-12 11:10 +0200
  [PATCH 2/3] regulator: qcom_smd: Fix voltage ranges for pma8084 ftsmps and pldo Stephen Boyd <sboyd@codeaurora.org> - 2016-07-12 00:00 +0200
    Re: [PATCH 2/3] regulator: qcom_smd: Fix voltage ranges for pma8084  ftsmps and pldo Andy Gross <andy.gross@linaro.org> - 2016-07-12 00:40 +0200

csiph-web