Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1440912

Re: [PATCH V8 2/2] regulator: mt6323: Add support for MT6323 regulator

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Jul 11, 2016 at 02:29:39PM +0200, John Crispin wrote:

> +static const struct of_device_id mt6323_of_match[] = {
> +	{ .compatible = "mediatek,mt6323-regulator", },
> +	{ /* sentinel */ },
> +};
> +MODULE_DEVICE_TABLE(of, mt6323_of_match);

This may have been answered last time but I don't remember - why is
there a compatible string for this device in the DT?  Surely we already
know that the regulators for the mt6323 are present by virtue of the
fact that we know that the core mt6323 is present in the system?
Indeed, looking at the now merged MFD code it appears that this is
in fact the case so we could just not have a compatible and perhaps this
was just an oversight.  This is good because it means we're not encoding
the specific way Linux instantiates devices into the DT.

Otherwise this does look good.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V8 1/2] regulator: Add document for MT6323 regulator John Crispin <john@phrozen.org> - 2016-07-11 14:40 +0200
  [PATCH V8 2/2] regulator: mt6323: Add support for MT6323 regulator John Crispin <john@phrozen.org> - 2016-07-11 14:40 +0200
    Re: [PATCH V8 2/2] regulator: mt6323: Add support for MT6323  regulator Mark Brown <broonie@kernel.org> - 2016-07-11 23:20 +0200
  Re: [PATCH V8 1/2] regulator: Add document for MT6323 regulator Mark Brown <broonie@kernel.org> - 2016-07-11 20:10 +0200
    Re: [PATCH V8 1/2] regulator: Add document for MT6323 regulator John Crispin <john@phrozen.org> - 2016-07-11 21:00 +0200
      Re: [PATCH V8 1/2] regulator: Add document for MT6323 regulator Mark Brown <broonie@kernel.org> - 2016-07-11 21:30 +0200
        Re: [PATCH V8 1/2] regulator: Add document for MT6323 regulator John Crispin <john@phrozen.org> - 2016-07-11 22:40 +0200
          Re: [PATCH V8 1/2] regulator: Add document for MT6323 regulator Mark Brown <broonie@kernel.org> - 2016-07-11 23:10 +0200

csiph-web