Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1440778

Re: [PATCH] Input: /input/mouse/elan_i2c_core.c Fix some Asus touchapod which casue TP no funciton sometimes, the patch detect some specific touchpad and run a special initialize

Show all headers | View raw

On Mon, Jul 11, 2016 at 08:40:58PM +0800, 廖崇榮 wrote:
> > +
> > +	error = data->ops->get_sm_version(client, &data->ic_type,
> > +					  &data->sm_version);
> > +	if (error)
> > +		return false;
> 
> That means we'd be fetching product ID and IC type twice when initializing the device. Can we come with a way to do it once?
> [KT]:Because the elan_query_device_info() is behind the elan_initialize(). That's why I fetching product ID and IC type in the elan_initialize()
>     I will discuss with FW team and then execute elan_query_device_info() first to get product_id and ic_type. 

We might need to split fetching product ID and IC type form the rest of
the device info.

Thanks.

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

RE: [PATCH] Input: /input/mouse/elan_i2c_core.c Fix some Asus touchapod which casue TP no funciton sometimes, the patch detect some specific touchpad and run a special initialize 廖崇榮 <kt.liao@emc.com.tw> - 2016-07-11 14:50 +0200
  Re: [PATCH] Input: /input/mouse/elan_i2c_core.c Fix some Asus  touchapod which casue TP no funciton sometimes, the patch detect some  specific touchpad and run a special initialize 'Dmitry Torokhov' <dmitry.torokhov@gmail.com> - 2016-07-11 19:10 +0200
    RE: [PATCH] Input: /input/mouse/elan_i2c_core.c Fix some Asus touchapod which casue TP no funciton sometimes, the patch detect some specific touchpad and run a special initialize 廖崇榮 <kt.liao@emc.com.tw> - 2016-07-12 16:20 +0200

csiph-web