Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1440695

Re: [PATCH] usb:solve resume usb device identification problem

Show all headers | View raw

On Mon, 11 Jul 2016, Pengcheng Li wrote:

> A usb device in the connection state. Then host is suspend and resume.
> But the usb device could not be at the right speed. We should be reset
> the reset.
> 
> Signed-off-by: Pengcheng Li <lpc.li@hisilicon.com>

Why wouldn't the USB device be at the right speed?

You should _not_ reset the device if it is at the right speed.

> @@ -3512,6 +3512,10 @@ int usb_port_resume(struct usb_device *udev, pm_message_t msg)
>  		}
>  	}
>  
> +	retval = hub_port_reset(hub, port1, udev, HUB_ROOT_RESET_TIME, false);
> +	if (retval < 0)
> +		hub_port_disable(hub, port1, 0);
> +

Most of the time (for example, for non-USB3 devices) this would be 
wrong.

Alan Stern

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] usb:solve resume usb device identification problem Pengcheng Li <lpc.li@hisilicon.com> - 2016-07-11 15:10 +0200
  Re: [PATCH] usb:solve resume usb device identification problem Alan Stern <stern@rowland.harvard.edu> - 2016-07-11 17:00 +0200
    RE: [PATCH] usb:solve resume usb device identification problem Lipengcheng <lpc.li@hisilicon.com> - 2016-07-12 03:50 +0200
  Re: [PATCH] usb:solve resume usb device identification problem Lu Baolu <baolu.lu@linux.intel.com> - 2016-07-12 02:50 +0200
    RE: [PATCH] usb:solve resume usb device identification problem Lipengcheng <lpc.li@hisilicon.com> - 2016-07-12 04:00 +0200
      Re: [PATCH] usb:solve resume usb device identification problem Lu Baolu <baolu.lu@linux.intel.com> - 2016-07-12 04:30 +0200
        RE: [PATCH] usb:solve resume usb device identification problem Lipengcheng <lpc.li@hisilicon.com> - 2016-07-12 13:40 +0200

csiph-web