Re: [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

From	Vinay Simha <simhavcs@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel
Date	2016-07-11 14:40 +0200
Message-ID	<rTIFe-70u-77@gated-at.bofh.it> (permalink)
References	<rM0pz-4g5-3@gated-at.bofh.it> <rM0pz-4g5-9@gated-at.bofh.it> <rP3AB-ys-1@gated-at.bofh.it> <rQYwN-68C-3@gated-at.bofh.it> <rTIvv-6WO-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

emil,

As you had suggested to drop the spurious returns in
jdi_panel_unprepare and drop the return itself.
But as i had mentioned earlier , we cannot drop the return function
and void for jdi_panel_unprepare , since the drm fun* requires int as
return type (drm_panel_funcs .unprepare).

please do re-point out if i had still missed anything.

fyi,
v7:
 * emil review comments incorporated
   added ARRAY_SIZE in struct, regulator_bulk_disable in poweroff,
   gpios checks dropped.
   some returns cannot be dropped, since drm panel framework return
   type required.

On Mon, Jul 11, 2016 at 5:50 PM, Thierry Reding
<thierry.reding@gmail.com> wrote:
> On Sun, Jul 03, 2016 at 11:52:11PM +0100, Emil Velikov wrote:
>> On 28 June 2016 at 16:59, Vinay Simha <simhavcs@gmail.com> wrote:
>> > hi,
>> >
>> > Any further comments or reviews?
>> >
>> You still haven't covered my earlier suggestions, as such I cannot
>> give you a r-b :-( They are not blockers by any means, but it'll be
>> up-to the maintainer to ack/pick this up.
>>
>> Thierry ?
>
> Vinay, please address Emil's comments and resend. I also see that you
> stopped sending the device tree bindings patch at some point. Please do
> include that when you repost as I don't seem to be able to find a recent
> version anywhere.
>
> Thierry

-- 
Regards,

Vinay Simha.B.N.

Thread

Re: [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel Thierry Reding <thierry.reding@gmail.com> - 2016-07-11 14:30 +0200
  Re: [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel Vinay Simha <simhavcs@gmail.com> - 2016-07-11 14:40 +0200
    Re: [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel Emil Velikov <emil.l.velikov@gmail.com> - 2016-07-11 16:20 +0200

csiph-web