Re: [RFC PATCH 3/3] perf: util: only open events on CPUs an evsel permits

From	Mark Rutland <mark.rutland@arm.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 3/3] perf: util: only open events on CPUs an evsel permits
Date	2016-07-11 13:00 +0200
Message-ID	<rTH6r-5VY-31@gated-at.bofh.it> (permalink)
References	<rSk2d-Ok-9@gated-at.bofh.it> <rSk2d-Ok-11@gated-at.bofh.it> <rSyRz-1NP-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jul 08, 2016 at 09:55:14AM +0200, Jiri Olsa wrote:
> On Thu, Jul 07, 2016 at 05:04:34PM +0100, Mark Rutland wrote:
> > +		if (!cpu_map__has(evsel->cpus, evlist_cpu))
> > +			continue;
> > +
> > +		cpu = cpu_map__idx(evsel->cpus, evlist_cpu);
> 
> you basicaly call cpu_map__idx twice in here,
> I think it might be better call it just once
> and check the cpu for -1

Sure, I can change the patch to do that.

Mark.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH 3/3] perf: util: only open events on CPUs an evsel permits Mark Rutland <mark.rutland@arm.com> - 2016-07-07 18:10 +0200
  Re: [RFC PATCH 3/3] perf: util: only open events on CPUs an evsel  permits Jiri Olsa <jolsa@redhat.com> - 2016-07-08 10:00 +0200
    Re: [RFC PATCH 3/3] perf: util: only open events on CPUs an evsel  permits Mark Rutland <mark.rutland@arm.com> - 2016-07-11 13:00 +0200

csiph-web