Re: [PATCH 5/7] bus: vexpress-config: add missing of_node_put after calling of_parse_phandle

From	Liviu Dudau <liviu.dudau@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/7] bus: vexpress-config: add missing of_node_put after calling of_parse_phandle
Date	2016-07-11 11:10 +0200
Message-ID	<rTFnX-4Z1-5@gated-at.bofh.it> (permalink)
References	<rQ41z-5v6-9@gated-at.bofh.it> <rTFnY-4Z1-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jul 01, 2016 at 05:41:59PM +0800, Peter Chen wrote:
> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using.
> 
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> Cc: Sudeep Holla <sudeep.holla@arm.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>

Acked-by: Liviu Dudau <Liviu.Dudau@arm.com>

> ---
>  drivers/bus/vexpress-config.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bus/vexpress-config.c b/drivers/bus/vexpress-config.c
> index c3cb76b..9efdf1d 100644
> --- a/drivers/bus/vexpress-config.c
> +++ b/drivers/bus/vexpress-config.c
> @@ -178,6 +178,7 @@ static int vexpress_config_populate(struct device_node *node)
>  
>  	parent = class_find_device(vexpress_config_class, NULL, bridge,
>  			vexpress_config_node_match);
> +	of_node_put(bridge);
>  	if (WARN_ON(!parent))
>  		return -ENODEV;
>  
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 5/7] bus: vexpress-config: add missing of_node_put after  calling of_parse_phandle Liviu Dudau <liviu.dudau@arm.com> - 2016-07-11 11:10 +0200

csiph-web