Re: [tip:x86/debug] printk: Make the printk*once() variants return a value

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [tip:x86/debug] printk: Make the printk*once() variants return a value
Date	2016-07-09 20:00 +0200
Message-ID	<rT4HM-65B-23@gated-at.bofh.it> (permalink)
References	<rRkGZ-2Z3-3@gated-at.bofh.it> <rSCLw-4Br-57@gated-at.bofh.it> <rSQv7-5aV-3@gated-at.bofh.it> <rSVl7-8qY-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, 2016-07-09 at 09:50 +0200, Borislav Petkov wrote:
> On Fri, Jul 08, 2016 at 07:40:48PM -0700, Joe Perches wrote:
> > This change isn't described in the commit message and there
> > doesn't seem to be a need to change this.
> How do *you* know? Did *you* actually sit down and build a kernel with
> your proposed change before sending a reply?
> I'm pretty sure you didn't.

defconfigs both with and without CONFIG_PRINTK build
properly with the proposed change to this specific patch.

> Well, there is a very good reason why I made that change but I'm not
> going to tell you.

Borislav, your delightful personality always impresses.
Never change.

If there is a specific reason you know why this 0; value
must be added to a do {} while (0) to statement expression
macro conversion, it'd be good to write that in the
commit message.  It'd also be good to remove the useless
"do {} while (0);" surrounding a single statement.

Thread

[PATCH -v2 2/3] printk: Make the printk*once() variants return a value Borislav Petkov <bp@alien8.de> - 2016-07-05 00:40 +0200
  [tip:x86/debug] printk: Make the printk*once() variants return a  value tip-bot for Borislav Petkov <tipbot@zytor.com> - 2016-07-08 14:10 +0200
    Re: [tip:x86/debug] printk: Make the printk*once() variants return  a value Joe Perches <joe@perches.com> - 2016-07-09 04:50 +0200
      Re: [tip:x86/debug] printk: Make the printk*once() variants return a  value Borislav Petkov <bp@alien8.de> - 2016-07-09 10:00 +0200
        Re: [tip:x86/debug] printk: Make the printk*once() variants return  a value Joe Perches <joe@perches.com> - 2016-07-09 20:00 +0200
          Re: [tip:x86/debug] printk: Make the printk*once() variants return a  value Borislav Petkov <bp@alien8.de> - 2016-07-10 09:00 +0200
            Re: [tip:x86/debug] printk: Make the printk*once() variants return  a value Joe Perches <joe@perches.com> - 2016-07-10 10:30 +0200
              Re: [tip:x86/debug] printk: Make the printk*once() variants return a  value Borislav Petkov <bp@alien8.de> - 2016-07-10 14:10 +0200
                Re: [tip:x86/debug] printk: Make the printk*once() variants return  a value Joe Perches <joe@perches.com> - 2016-07-10 14:40 +0200

csiph-web