Re: [PATCH v2 1/6] dt-bindings: clock: add DT binding for the Xtal clock on Armada 3700

From	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/6] dt-bindings: clock: add DT binding for the Xtal clock on Armada 3700
Date	2016-07-08 09:40 +0200
Message-ID	<rSyye-1Gq-11@gated-at.bofh.it> (permalink)
References	<rSq7D-4C3-5@gated-at.bofh.it> <rSq7D-4C3-13@gated-at.bofh.it>
Organization	Free Electrons

Show all headers | View raw

Hello,

On Fri,  8 Jul 2016 00:37:46 +0200, Gregory CLEMENT wrote:

> +gpio1: gpio@13800 {
> +	compatible = "marvell,mvebu-gpio-3700",	"syscon", "simple-mfd";

I find this compatible string not very consistent with what we do for
other drivers, it should have been:

	marvell,armada-3700-gpio

or something like that.


> +	xtalclk: xtal-clk {
> +		compatible = "marvell,armada-3700-xtal-clock";

See here for example.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/6] dt-bindings: clock: add DT binding for the Xtal clock on Armada 3700 Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-07-08 00:40 +0200
  Re: [PATCH v2 1/6] dt-bindings: clock: add DT binding for the Xtal  clock on Armada 3700 Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-07-08 09:40 +0200

csiph-web