Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1439102

Re: [PATCH 1/2] HID: logitech-hidpp: add battery support for HID++ 2.0 devices

Show all headers | View raw

On Fri, Jul 08, 2016 at 01:21:08AM +0200, Bastien Nocera wrote:
> On Wed, 2016-06-29 at 19:28 +1000, Peter Hutterer wrote:
> > If the 0x1000 Unified Battery Level Status feature exists, expose the
> > battery
> > level.
> > 
> > The main drawback is that while a device is plugged in its battery
> > level is 0.
> > To avoid exposing that as 0% charge we make up a number based on the
> > charging
> > status.
> 
> This will require changes in UPower, so that it doesn't try to access
> the Logitech unifying devices via user-space, and uses the data from
> the kernel. Did you already file a bug?

filed now: https://bugs.freedesktop.org/show_bug.cgi?id=96857

> Note that this would also mean losing the "lux" information, but I
> don't think that's something we're that interested in exposing.

Adding that HID++ request to the kernel would be easy enough but I don't 
see anything in the power_supply_property that would match this, do you? 
Also, I don't have such a device so testing would be tricky.

Cheers,
   Peter


> 
> For example, for a keyboard that recharges via solar panels, at night:
> 
> Device: /org/freedesktop/UPower/devices/keyboard_0003o046Do4002x0004
>   native-path:          /sys/devices/pci0000:00/0000:00:14.0/usb3/3-10/3-10:1.2/0003:046D:C52B.0003/0003:046D:4002.0004
>   vendor:               Logitech, Inc.
>   model:                K750
>   serial:               197F3F23
>   power supply:         no
>   updated:              Fri 08 Jul 2016 01:17:40 CEST (95 seconds ago)
>   has history:          yes
>   has statistics:       no
>   keyboard
>     present:             yes
>     rechargeable:        yes
>     state:               discharging
>     warning-level:       none
>     luminosity:          16 lx
>     percentage:          89%
>     icon-name:          'battery-full-symbolic'

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] HID: logitech-hidpp: add battery support for HID++ 2.0 devices Peter Hutterer <peter.hutterer@who-t.net> - 2016-06-29 12:00 +0200
  [PATCH 2/2] HID: logitech-hidpp: remove HIDPP_QUIRK_CONNECT_EVENTS Peter Hutterer <peter.hutterer@who-t.net> - 2016-06-29 12:00 +0200
  Re: [PATCH 1/2] HID: logitech-hidpp: add battery support for HID++  2.0 devices Jiri Kosina <jikos@kernel.org> - 2016-07-07 11:40 +0200
  Re: [PATCH 1/2] HID: logitech-hidpp: add battery support for HID++  2.0 devices Bastien Nocera <hadess@hadess.net> - 2016-07-08 01:30 +0200
    Re: [PATCH 1/2] HID: logitech-hidpp: add battery support for HID++  2.0 devices Peter Hutterer <peter.hutterer@who-t.net> - 2016-07-08 06:40 +0200
  Re: [PATCH 1/2] HID: logitech-hidpp: add battery support for HID++  2.0 devices Bastien Nocera <hadess@hadess.net> - 2016-07-08 16:40 +0200
    Re: [PATCH 1/2] HID: logitech-hidpp: add battery support for HID++  2.0 devices Bastien Nocera <hadess@hadess.net> - 2016-07-08 19:40 +0200
      Re: [PATCH 1/2] HID: logitech-hidpp: add battery support for HID++  2.0 devices Jiri Kosina <jikos@kernel.org> - 2016-07-08 20:30 +0200

csiph-web