Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1438944

[PATCH] CFLAGS: add -Wunused-but-set-parameter

Path csiph.com!news.freedyn.net!newsfeed.datemas.de!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From Alexey Dobriyan <adobriyan@gmail.com>
Newsgroups linux.kernel
Subject [PATCH] CFLAGS: add -Wunused-but-set-parameter
Date Thu, 07 Jul 2016 23:50:01 +0200
Message-ID <rSplf-43R-3@gated-at.bofh.it> (permalink)
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=ek8IQbBZkbJdqefCx5U9GZo+00TJcdJTWuzVV2MN3EY=; b=QidKDk0aQKVH52RynXYZNNqEfOxbfbm0E8taVJN8Yk4TuhpnXx/aBNDm3++denDvE4 obl8jBGLtRvWnbwKEiuk94+ffbY+2pkGhhKZy2ZWx/hIghuc4rkYLoFY2H3g5dqmg5mp NqGG8CQHJCsEiJiPnhP+TwGMbjTk+MO2r48v6uO1lME/MbMIr/8pX06Hxivv6MV1ik7C xSt4BCRZtgMoGGSwAlxsDPBWEmenpxJUaGchmZh0p2hPmZc5JQVDmcXy69VGyigEqcOj RP94lMjgH+OOssLVdwAWAyGyE4VYMPp81CQ7HqBPg9NSvq/s+mmSAUII+Go7BADDpUby OILw==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=ek8IQbBZkbJdqefCx5U9GZo+00TJcdJTWuzVV2MN3EY=; b=PD6nof1J5Z6nr0hPxjU8MX+vOkPacMvjIqaq5GzMn0p5nmrEf/PsSNmU3PDSHRtN52 YqN5nfoT1pvibTxGHorfcu8ycqB/lXERIHCTeYH4DZZ+2fWOB7yhQmDb+TEIcC0zRofN Nl2BmAGrSbHeTTDf1bY2v9RFnLyKJGERpJAYOpVxss+4wUpYhEPIHWrffAqUu/9ej6mG TQ7W7SAGJKyFqQe5aeRf5kGLdmDOR4Ayj5oUB+ZtgFHM4W41W1fMHEYU7cM7LspCZAcV FyIn42Wea8tcrqIkzqfOA4n4JiK1dogGv41MPFzEVGbolxl/HUVMqsS9dzx08wSwvHbO iKMQ==
X-Gm-Message-State ALyK8tKe4H0OUaKQdLS8ogbt0b2r5Tu/499NhioKnBz5QVhZFKi0r8RnppJAiKfckQEyAQ==
X-Received by 10.25.76.195 with SMTP id z186mr538434lfa.155.1467927789151; Thu, 07 Jul 2016 14:43:09 -0700 (PDT)
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.5.24 (2015-08-30)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 26
Organization linux.* mail to news gateway
X-Original-Cc linux-kernel@vger.kernel.org
X-Original-Date Fri, 8 Jul 2016 00:43:06 +0300
X-Original-Message-ID <20160707214306.GB31678@p183.telecom.by>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1438944

Show key headers only | View raw


-Wunused-but-set-parameter is finding stuff with current allmodconfig:

drivers/misc/mic/scif/scif_dma.c:118:27: warning: parameter 'ep' set but not used [-Wunused-but-set-parameter]
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:2156:8: warning: parameter 'function' set but not used [-Wunused-but-set-parameter]
drivers/net/ethernet/ti/tlan.c:1647:59: warning: parameter 'host_int' set but not used [-Wunused-but-set-parameter]
drivers/usb/gadget/udc/pxa27x_udc.c:1828:74: warning: parameter 'driver' set but not used [-Wunused-but-set-parameter]

and judging by changelogs, people were using it before,
but were too scared to touch top level Makefile.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 Makefile |    1 +
 1 file changed, 1 insertion(+)

--- a/Makefile
+++ b/Makefile
@@ -399,6 +399,7 @@ KBUILD_CFLAGS   := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
 		   -Werror-implicit-function-declaration \
 		   -Wno-format-security \
 		   -std=gnu89
+KBUILD_CFLAGS += -Wunused-but-set-parameter
 
 KBUILD_AFLAGS_KERNEL :=
 KBUILD_CFLAGS_KERNEL :=

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH] CFLAGS: add -Wunused-but-set-parameter Alexey Dobriyan <adobriyan@gmail.com> - 2016-07-07 23:50 +0200

csiph-web