Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1438624

Re: [PATCH v4 1/2] clk: exynos5433: do not use CLK_IGNORE_UNUSED for SPI clocks

Show all headers | View raw

Hi Krzysztof,

> > The CLK_IGNORE_UNUSED flag has to be avoided whenever possible.
> > Use the CLK_IS_CRITICAL flag instead for critical SPI1 clocks,
> > which enables the clock line during boot time.
> 
> I don't agree. Both flags should be avoided. Clk is critical does not
> solve the problem. It is just a better workaround for lack of proper
> clock consumers.
> 
> The IOCLK is not a critical clock. It can be disabled (e.g. when SoC is
> used on a board without any SPI device connected).

As we discussed offline there is no driver which is requesting
this clock. We cannot ask to the spi driver to handle three
clocks because the exynos5433 has its own peculiarities.

If we want this on the spi driver's side, we need to add a new
compatible and check it everytime. To me it looks uglier than
just keep it alive.

Thanks,
Andi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 1/2] clk: exynos5433: do not use CLK_IGNORE_UNUSED for SPI  clocks Andi Shyti <andi.shyti@samsung.com> - 2016-07-07 14:20 +0200
  Re: [PATCH v4 1/2] clk: exynos5433: do not use CLK_IGNORE_UNUSED for  SPI clocks Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-07-07 14:50 +0200
    Re: [PATCH v4 1/2] clk: exynos5433: do not use CLK_IGNORE_UNUSED for  SPI clocks Andi Shyti <andi.shyti@samsung.com> - 2016-07-07 15:30 +0200
      Re: [PATCH v4 1/2] clk: exynos5433: do not use CLK_IGNORE_UNUSED for  SPI clocks Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-07-07 17:30 +0200
        Re: [PATCH v4 1/2] clk: exynos5433: do not use CLK_IGNORE_UNUSED for  SPI clocks Andi Shyti <andi@etezian.org> - 2016-07-07 17:40 +0200

csiph-web