Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1438539
| From | David Vrabel <david.vrabel@citrix.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [Xen-devel] [PATCH 1/2] xenbus: don't bail early from xenbus_dev_request_and_reply() |
| Date | 2016-07-07 13:40 +0200 |
| Message-ID | <rSfOW-6im-9@gated-at.bofh.it> (permalink) |
| References | <rSbUZ-3OW-25@gated-at.bofh.it> <rSc4G-3S8-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 07/07/16 08:32, Jan Beulich wrote:
> We must not skip the transaction_end() call for a failed
> XS_TRANSACTION_START. The removed code fragment got introduced by
> commit 027bd7e899 ("xen/xenbus: Avoid synchronous wait on XenBus
> stalling shutdown/restart") without its description really indicating
> why it was added (and hence I can't identify whether a more complex
> change might be needed here).
If sending the XS_TRANSACTION_END message failed, then the transaction
is still open and transaction_end() should not be called.
However, if sending an XS_TRANSACTION_START failed, then
transaction_end() should be called.
So, yes a more complex fix is needed here.
David
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/2] xenbus: xenbus_dev_request_and_reply() adjustments "Jan Beulich" <JBeulich@suse.com> - 2016-07-07 09:30 +0200
[PATCH 2/2] xenbus: simplify xenbus_dev_request_and_reply() "Jan Beulich" <JBeulich@suse.com> - 2016-07-07 09:40 +0200
[PATCH 1/2] xenbus: don't bail early from xenbus_dev_request_and_reply() "Jan Beulich" <JBeulich@suse.com> - 2016-07-07 09:40 +0200
Re: [Xen-devel] [PATCH 1/2] xenbus: don't bail early from xenbus_dev_request_and_reply() David Vrabel <david.vrabel@citrix.com> - 2016-07-07 13:40 +0200
Re: [Xen-devel] [PATCH 1/2] xenbus: don't bail early from xenbus_dev_request_and_reply() "Jan Beulich" <JBeulich@suse.com> - 2016-07-07 14:10 +0200
Re: [Xen-devel] [PATCH 1/2] xenbus: don't bail early from xenbus_dev_request_and_reply() David Vrabel <david.vrabel@citrix.com> - 2016-07-07 14:20 +0200
Re: [Xen-devel] [PATCH 1/2] xenbus: don't bail early from xenbus_dev_request_and_reply() "Jan Beulich" <JBeulich@suse.com> - 2016-07-07 14:30 +0200
Re: [Xen-devel] [PATCH 1/2] xenbus: don't bail early from xenbus_dev_request_and_reply() David Vrabel <david.vrabel@citrix.com> - 2016-07-07 15:20 +0200
Re: [Xen-devel] [PATCH 1/2] xenbus: don't bail early from xenbus_dev_request_and_reply() David Vrabel <david.vrabel@citrix.com> - 2016-07-07 15:30 +0200
Re: [Xen-devel] [PATCH 1/2] xenbus: don't bail early from xenbus_dev_request_and_reply() "Jan Beulich" <JBeulich@suse.com> - 2016-07-07 16:00 +0200
Re: [Xen-devel] [PATCH 1/2] xenbus: don't bail early from xenbus_dev_request_and_reply() David Vrabel <david.vrabel@citrix.com> - 2016-07-08 12:20 +0200
Re: [Xen-devel] [PATCH 0/2] xenbus: xenbus_dev_request_and_reply() adjustments David Vrabel <david.vrabel@citrix.com> - 2016-07-08 13:00 +0200
csiph-web