Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1438495

Re: [PATCH] arm64: dts: rockchip: support the usb2phy for rk3399 evb

Show all headers | View raw

Hi,

Am Donnerstag, 7. Juli 2016, 12:46:40 schrieb Caesar Wang:
> From: Frank Wang <frank.wang@rock-chips.com>
> 
> This patch adds the usb2phy needed dts node information for rk3399.
> 
> USB2.0 PHY is comprised of one Host port and one OTG port.
> Host Port is for USB2.0 host controller; OTG port is for USB2.0 part of
> USB3.0 OTG controller, and as a part to construct a fully feature TypeC
> subsystem.
> 
> The USB2.0 vbus gpio is board specific, it's no same with all rk3399
> boards, so move it into evb voard.
> 
> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> ---
> 
>  arch/arm64/boot/dts/rockchip/rk3399-evb.dts |  4 ++++
>  arch/arm64/boot/dts/rockchip/rk3399.dtsi    | 19 +++++++++++++++++++
>  2 files changed, 23 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index 4c84229..21d147f 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -242,6 +242,25 @@
>  		status = "disabled";
>  	};
> 
> +	usb2phy: usb2phy {
> +		compatible = "rockchip,rk3399-usb-phy";
> +		rockchip,grf = <&grf>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		usb2phy0: usb2-phy0 {
> +			#phy-cells = <0>;
> +			#clock-cells = <0>;
> +			reg = <0xe458>;
> +		};
> +
> +		usb2phy1: usb2-phy1 {
> +			#phy-cells = <0>;
> +			#clock-cells = <0>;
> +			reg = <0xe468>;
> +		};
> +	};
> +

The rk3399 uses the innosilicon usb2 phy and the binding we've come up for 
it looks a lot different than the above. So I'm not sure where this is 
coming from, especially as I haven't seen the driver part for the rk3399 at 
all yet. So far Frank was always working on te rk3366 variant, which seemed 
to be the most complete.


Heiko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] arm64: dts: rockchip: support the usb2phy for rk3399 evb Caesar Wang <wxt@rock-chips.com> - 2016-07-07 06:50 +0200
  Re: [PATCH] arm64: dts: rockchip: support the usb2phy for rk3399 evb Heiko Stuebner <heiko@sntech.de> - 2016-07-07 12:20 +0200

csiph-web