Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1438489

Re: [PATCH] spi: s3c64xx: do not disable the clock while configuring the spi

From Andi Shyti <andi.shyti@samsung.com>
Newsgroups linux.kernel
Subject Re: [PATCH] spi: s3c64xx: do not disable the clock while configuring the spi
Date 2016-07-07 12:10 +0200
Message-ID <rSepP-5v6-11@gated-at.bofh.it> (permalink)
References <rSepP-5v6-13@gated-at.bofh.it> <rSbUZ-3OW-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi,

>  	if (sdd->port_conf->clk_from_cmu) {
> -		/* Configure Clock */
> -		/* There is half-multiplier before the SPI */
>  		clk_set_rate(sdd->src_clk, sdd->cur_speed * 2);

sorry, I will re-send it because I should not remove the comments
above.... in the future someone might wonder why it's multiplied
by 2.

That's called auto review and auto-nack :)

Andi

> -		/* Enable Clock */
> -		clk_prepare_enable(sdd->src_clk);
>  	} else {
>  		/* Configure Clock */
>  		val = readl(regs + S3C64XX_SPI_CLK_CFG);
> -- 
> 2.8.1
> 

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] spi: s3c64xx: do not disable the clock while configuring the  spi Andi Shyti <andi.shyti@samsung.com> - 2016-07-07 09:30 +0200
  Re: [PATCH] spi: s3c64xx: do not disable the clock while configuring  the spi Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-07-07 11:50 +0200
  Re: [PATCH] spi: s3c64xx: do not disable the clock while configuring  the spi Andi Shyti <andi.shyti@samsung.com> - 2016-07-07 12:10 +0200
    Re: [PATCH] spi: s3c64xx: do not disable the clock while configuring  the spi Mark Brown <broonie@kernel.org> - 2016-07-07 14:30 +0200
  Applied "spi: s3c64xx: do not disable the clock while configuring the spi" to the spi tree Mark Brown <broonie@kernel.org> - 2016-07-07 12:10 +0200

csiph-web