Re: [PATCH 09/31] mm, vmscan: by default have direct reclaim only shrink once per node

From	Mel Gorman <mgorman@techsingularity.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 09/31] mm, vmscan: by default have direct reclaim only shrink once per node
Date	2016-07-07 12:30 +0200
Message-ID	<rSeJb-5D9-15@gated-at.bofh.it> (permalink)
References	<rQcVb-2Ax-3@gated-at.bofh.it> <rQcVd-2Ax-69@gated-at.bofh.it> <rS6BX-av-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jul 07, 2016 at 10:43:22AM +0900, Joonsoo Kim wrote:
> > @@ -2600,6 +2593,16 @@ static void shrink_zones(struct zonelist *zonelist, struct scan_control *sc)
> >  			classzone_idx--;
> >  
> >  		/*
> > +		 * Shrink each node in the zonelist once. If the zonelist is
> > +		 * ordered by zone (not the default) then a node may be
> > +		 * shrunk multiple times but in that case the user prefers
> > +		 * lower zones being preserved
> > +		 */
> > +		if (zone->zone_pgdat == last_pgdat)
> > +			continue;
> > +		last_pgdat = zone->zone_pgdat;
> > +
> > +		/*
> 
> After this change, compaction_ready() which uses zone information
> would be called with highest zone in node. So, if some lower zone in
> that node is compaction-ready, we cannot stop the reclaim.
> 

Yes. It only impacts direct reclaim but potentially it's an issue. I'll
fix it.

-- 
Mel Gorman
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 09/31] mm, vmscan: by default have direct reclaim only shrink once per node Mel Gorman <mgorman@techsingularity.net> - 2016-07-01 22:10 +0200
  Re: [PATCH 09/31] mm, vmscan: by default have direct reclaim only  shrink once per node Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-07-07 03:50 +0200
    Re: [PATCH 09/31] mm, vmscan: by default have direct reclaim only  shrink once per node Mel Gorman <mgorman@techsingularity.net> - 2016-07-07 12:30 +0200

csiph-web