Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1438437

Re: [PATCH v5 2/8] acpi: fix enumeration (visited) flags for bus rescans

Show all headers | View raw

On Fri, Jul 01, 2016 at 11:19:06PM +0300, Octavian Purdila wrote:
> If the ACPI tables changes as a result of a dinamically loaded table and
> a bus rescan is required the enumeration/visited flag are not
> consistent.
> 
> I2C/SPI are not directly enumerated in acpi_bus_attach(), however the
> visited flag is set. This makes it impossible to check if an ACPI device
> has already been enumerated by the I2C and SPI subsystems. To fix this
> issue we only set the visited flags if the device is not I2C or SPI.
> 
> With this change we also need to remove setting visited to false from
> acpi_bus_attach(), otherwise if we rescan already enumerated I2C/SPI
> devices we try to re-enumerate them.
> 
> Note that I2C/SPI devices can be enumerated either via a scan handler
> (when using PRP0001) or via regular device_attach(). In either case
> the flow goes through acpi_default_enumeration() which makes it the
> ideal place to mark the ACPI device as enumerated.
> 
> Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 0/8]  ACPI overlays Octavian Purdila <octavian.purdila@intel.com> - 2016-07-01 22:30 +0200
  [PATCH v5 2/8] acpi: fix enumeration (visited) flags for bus rescans Octavian Purdila <octavian.purdila@intel.com> - 2016-07-01 22:30 +0200
    Re: [PATCH v5 2/8] acpi: fix enumeration (visited) flags for bus  rescans Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-07-06 17:10 +0200
      Re: [PATCH v5 2/8] acpi: fix enumeration (visited) flags for bus rescans Octavian Purdila <octavian.purdila@intel.com> - 2016-07-06 17:40 +0200
        Re: [PATCH v5 2/8] acpi: fix enumeration (visited) flags for bus rescans "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-07-06 23:10 +0200
          Re: [PATCH v5 2/8] acpi: fix enumeration (visited) flags for bus  rescans Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-07-07 11:10 +0200
    Re: [PATCH v5 2/8] acpi: fix enumeration (visited) flags for bus  rescans Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-07-07 11:30 +0200
  [PATCH v5 7/8] acpi: add support for configfs Octavian Purdila <octavian.purdila@intel.com> - 2016-07-01 22:30 +0200
    Re: [PATCH v5 7/8] acpi: add support for configfs Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-07-07 11:50 +0200
  [PATCH v5 3/8] acpi: add support for ACPI reconfiguration notifiers Octavian Purdila <octavian.purdila@intel.com> - 2016-07-01 22:30 +0200
    Re: [PATCH v5 3/8] acpi: add support for ACPI reconfiguration  notifiers Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-07-07 11:40 +0200
  [PATCH v5 6/8] efi: load SSTDs from EFI variables Octavian Purdila <octavian.purdila@intel.com> - 2016-07-01 22:30 +0200
    Re: [PATCH v5 6/8] efi: load SSTDs from EFI variables Geert Uytterhoeven <geert@linux-m68k.org> - 2016-07-02 10:20 +0200
    Re: [PATCH v5 6/8] efi: load SSTDs from EFI variables Matt Fleming <matt@codeblueprint.co.uk> - 2016-07-04 14:10 +0200
  [PATCH v5 1/8] Documentation: acpi: add SSDT overlays documentation Octavian Purdila <octavian.purdila@intel.com> - 2016-07-01 22:30 +0200
    Re: [PATCH v5 1/8] Documentation: acpi: add SSDT overlays  documentation Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-07-07 11:30 +0200
  [PATCH v5 8/8] acpi: add support for loading SSDTs via configfs Octavian Purdila <octavian.purdila@intel.com> - 2016-07-01 22:30 +0200
    Re: [PATCH v5 8/8] acpi: add support for loading SSDTs via configfs Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-07-07 11:50 +0200
  [PATCH v5 5/8] spi: add support for ACPI reconfigure notifications Octavian Purdila <octavian.purdila@intel.com> - 2016-07-01 22:30 +0200
    Re: [PATCH v5 5/8] spi: add support for ACPI reconfigure  notifications Mark Brown <broonie@kernel.org> - 2016-07-03 14:20 +0200
  [PATCH v5 4/8] i2c: add support for ACPI reconfigure notifications Octavian Purdila <octavian.purdila@intel.com> - 2016-07-01 22:30 +0200
    Re: [PATCH v5 4/8] i2c: add support for ACPI reconfigure  notifications Wolfram Sang <wsa@the-dreams.de> - 2016-07-04 02:40 +0200
  Re: [PATCH v5 0/8]  ACPI overlays "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-07-06 02:40 +0200
    Re: [PATCH v5 0/8] ACPI overlays Octavian Purdila <octavian.purdila@intel.com> - 2016-07-06 08:30 +0200

csiph-web