Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1438260

[PATCH 12/17] lightnvm: remove unused lists from struct rrpc_block

Show all headers | View raw

The ->list, ->open_list, and ->closed_list lists were previously used
for statistics. However, their usage have been removed, and thus these
can safely be removed.

Signed-off-by: Matias Bjørling <m@bjorling.me>
---
 drivers/lightnvm/rrpc.c | 9 ---------
 drivers/lightnvm/rrpc.h | 8 --------
 2 files changed, 17 deletions(-)

diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c
index c3a6f34..10ed22b 100644
--- a/drivers/lightnvm/rrpc.c
+++ b/drivers/lightnvm/rrpc.c
@@ -205,7 +205,6 @@ static struct rrpc_block *rrpc_get_blk(struct rrpc *rrpc, struct rrpc_lun *rlun,
 	}
 
 	rblk = rrpc_get_rblk(rlun, blk->id);
-	list_add_tail(&rblk->list, &rlun->open_list);
 	spin_unlock(&lun->lock);
 
 	blk->priv = rblk;
@@ -224,7 +223,6 @@ static void rrpc_put_blk(struct rrpc *rrpc, struct rrpc_block *rblk)
 
 	spin_lock(&lun->lock);
 	nvm_put_blk_unlocked(rrpc->dev, rblk->parent);
-	list_del(&rblk->list);
 	spin_unlock(&lun->lock);
 }
 
@@ -511,16 +509,11 @@ static void rrpc_gc_queue(struct work_struct *work)
 	struct rrpc *rrpc = gcb->rrpc;
 	struct rrpc_block *rblk = gcb->rblk;
 	struct rrpc_lun *rlun = rblk->rlun;
-	struct nvm_lun *lun = rblk->parent->lun;
 
 	spin_lock(&rlun->lock);
 	list_add_tail(&rblk->prio, &rlun->prio_list);
 	spin_unlock(&rlun->lock);
 
-	spin_lock(&lun->lock);
-	list_move_tail(&rblk->list, &rlun->closed_list);
-	spin_unlock(&lun->lock);
-
 	mempool_free(gcb, rrpc->gcb_pool);
 	pr_debug("nvm: block '%lu' is full, allow GC (sched)\n",
 							rblk->parent->id);
@@ -1194,8 +1187,6 @@ static int rrpc_luns_init(struct rrpc *rrpc, int lun_begin, int lun_end)
 
 		rlun->rrpc = rrpc;
 		INIT_LIST_HEAD(&rlun->prio_list);
-		INIT_LIST_HEAD(&rlun->open_list);
-		INIT_LIST_HEAD(&rlun->closed_list);
 
 		INIT_WORK(&rlun->ws_gc, rrpc_lun_gc);
 		spin_lock_init(&rlun->lock);
diff --git a/drivers/lightnvm/rrpc.h b/drivers/lightnvm/rrpc.h
index 5797343..448e39a 100644
--- a/drivers/lightnvm/rrpc.h
+++ b/drivers/lightnvm/rrpc.h
@@ -56,7 +56,6 @@ struct rrpc_block {
 	struct nvm_block *parent;
 	struct rrpc_lun *rlun;
 	struct list_head prio;
-	struct list_head list;
 
 #define MAX_INVALID_PAGES_STORAGE 8
 	/* Bitmap for invalid page intries */
@@ -77,13 +76,6 @@ struct rrpc_lun {
 	struct rrpc_block *blocks;	/* Reference to block allocation */
 
 	struct list_head prio_list;	/* Blocks that may be GC'ed */
-	struct list_head open_list;	/* In-use open blocks. These are blocks
-					 * that can be both written to and read
-					 * from
-					 */
-	struct list_head closed_list;	/* In-use closed blocks. These are
-					 * blocks that can _only_ be read from
-					 */
 
 	struct work_struct ws_gc;
 
-- 
2.1.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[GIT PULL 00/17] LightNVM pull request for 4.8 Matias Bjørling <m@bjorling.me> - 2016-07-07 10:00 +0200
  [PATCH 03/17] lightnvm: initialize ppa_addr in dev_to_generic_addr() Matias Bjørling <m@bjorling.me> - 2016-07-07 10:00 +0200
  [PATCH 06/17] lightnvm: remove checkpatch warning for unsigned ints Matias Bjørling <m@bjorling.me> - 2016-07-07 10:00 +0200
  [PATCH 12/17] lightnvm: remove unused lists from struct rrpc_block Matias Bjørling <m@bjorling.me> - 2016-07-07 10:00 +0200
  [PATCH 13/17] lightnvm: remove _unlocked variant of [get/put]_blk Matias Bjørling <m@bjorling.me> - 2016-07-07 10:00 +0200
  [PATCH 11/17] lightnvm: remove nested lock conflict with mm Matias Bjørling <m@bjorling.me> - 2016-07-07 10:00 +0200
  [PATCH 15/17] lightnvm: fix lun offset calculation for mark blk Matias Bjørling <m@bjorling.me> - 2016-07-07 10:00 +0200
  [PATCH 04/17] nvme: lightnvm: make MLC num_pairs little endian Matias Bjørling <m@bjorling.me> - 2016-07-07 10:00 +0200
  [PATCH 02/17] lightnvm: add media manager mark_blk helper Matias Bjørling <m@bjorling.me> - 2016-07-07 10:00 +0200
  [PATCH 05/17] lightnvm: Make functions not used by ouside static Matias Bjørling <m@bjorling.me> - 2016-07-07 10:00 +0200
  [PATCH 09/17] lightnvm: rename gennvm and update description Matias Bjørling <m@bjorling.me> - 2016-07-07 10:00 +0200
  [PATCH 17/17] lightnvm: make __nvm_submit_ppa static Matias Bjørling <m@bjorling.me> - 2016-07-07 10:00 +0200
  [PATCH 16/17] lightnvm: make ppa_list const in nvm_set_rqd_list Matias Bjørling <m@bjorling.me> - 2016-07-07 10:00 +0200
  [PATCH 07/17] lightnvm: fix checkpatch terse errors Matias Bjørling <m@bjorling.me> - 2016-07-07 10:00 +0200
  [PATCH 10/17] lightnvm: move target mgmt into media mgr Matias Bjørling <m@bjorling.me> - 2016-07-07 10:00 +0200
  [PATCH 14/17] lightnvm: make rrpc_map_page call nvm_get_blk outside locks Matias Bjørling <m@bjorling.me> - 2016-07-07 10:00 +0200
  [PATCH 01/17] lightnvm: break the loop when rqd is not null Matias Bjørling <m@bjorling.me> - 2016-07-07 10:00 +0200
  Re: [GIT PULL 00/17] LightNVM pull request for 4.8 Jens Axboe <axboe@kernel.dk> - 2016-07-07 17:00 +0200

csiph-web