Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1438220

[PATCH net-next 2/3] r8152: remove a netif_carrier_off in rtl8152_open function

Show all headers | View raw

After commit 90186af404ad ("r8152: fix lockup when runtime PM is enabled"),
the autoresume wouldn't start the device before rtl8152_open() is finished.
Therefore, we don't have to reset the linking status before and after
autoresume. That is, one of netif_carrier_off() in rtl8152_open() could be
removed.

Signed-off-by: Hayes Wang <hayeswang@realtek.com>
---
 drivers/net/usb/r8152.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index e005ee6..f1c5020 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -3111,8 +3111,6 @@ static int rtl8152_open(struct net_device *netdev)
 	if (res)
 		goto out;
 
-	netif_carrier_off(netdev);
-
 	res = usb_autopm_get_interface(tp->intf);
 	if (res < 0) {
 		free_all_mem(tp);
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next 0/3] r8152: remove the redundant code Hayes Wang <hayeswang@realtek.com> - 2016-07-07 09:20 +0200
  [PATCH net-next 1/3] r8152: remove rtl_phy_reset function Hayes Wang <hayeswang@realtek.com> - 2016-07-07 09:20 +0200
  [PATCH net-next 2/3] r8152: remove a netif_carrier_off in rtl8152_open function Hayes Wang <hayeswang@realtek.com> - 2016-07-07 09:20 +0200
  Re: [PATCH net-next 0/3] r8152: remove the redundant code David Miller <davem@davemloft.net> - 2016-07-09 23:50 +0200

csiph-web