Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1438214

[PATCH net-next 3/3] r8152: remove cancel_delayed_work_sync in rtl8152_set_speed

From Hayes Wang <hayeswang@realtek.com>
Newsgroups linux.kernel
Subject [PATCH net-next 3/3] r8152: remove cancel_delayed_work_sync in rtl8152_set_speed
Date 2016-07-07 09:20 +0200
Message-ID <rSbLj-3Kd-9@gated-at.bofh.it> (permalink)
References <rSbLk-3Kd-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


There is no conflict between the work_queue function and
rtl8152_set_speed(), so we don't have to cancel the delayed work in
rtl8152_set_speed().

Signed-off-by: Hayes Wang <hayeswang@realtek.com>
---
 drivers/net/usb/r8152.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index f1c5020..168a8e2 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -2829,7 +2829,6 @@ static int rtl8152_set_speed(struct r8152 *tp, u8 autoneg, u16 speed, u8 duplex)
 	u16 bmcr, anar, gbcr;
 	int ret = 0;
 
-	cancel_delayed_work_sync(&tp->schedule);
 	anar = r8152_mdio_read(tp, MII_ADVERTISE);
 	anar &= ~(ADVERTISE_10HALF | ADVERTISE_10FULL |
 		  ADVERTISE_100HALF | ADVERTISE_100FULL);
-- 
2.7.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH net-next 3/3] r8152: remove cancel_delayed_work_sync in rtl8152_set_speed Hayes Wang <hayeswang@realtek.com> - 2016-07-07 09:20 +0200

csiph-web