Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1439916
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Appana Durga Kedareswara Rao <appana.durga.rao@xilinx.com> |
| Newsgroups | linux.kernel |
| Subject | RE: [PATCH v12 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support |
| Date | Sat, 09 Jul 2016 10:40:01 +0200 |
| Message-ID | <rSVXP-tW-3@gated-at.bofh.it> (permalink) |
| References | <rQ4XD-64a-3@gated-at.bofh.it> <rQ4XE-64a-19@gated-at.bofh.it> <rSwPL-B6-5@gated-at.bofh.it> |
| X-Original-To | Vinod Koul <vinod.koul@intel.com> |
| Authentication-Results | spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; |
| Received-Spf | Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; |
| Thread-Topic | [PATCH v12 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support |
| Thread-Index | AQHR04zvOBTUf/CKMkqhC3+YW0hZr6ANjOSAgAJE8DA= |
| Accept-Language | en-US |
| Content-Language | en-US |
| X-Originating-IP | [172.23.229.239] |
| Content-Type | text/plain; charset="us-ascii" |
| Content-Transfer-Encoding | 8BIT |
| MIME-Version | 1.0 |
| X-Rcis-Action | ALLOW |
| X-Tm-As-Product-Ver | IMSS-7.1.0.1224-8.0.0.1202-22438.005 |
| X-Tm-As-User-Approved-Sender | Yes;Yes |
| X-Ms-Office365-Filtering-Ht | Tenant |
| X-Forefront-Antispam-Report | CIP:149.199.60.100;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(189002)(199003)(51914003)(586003)(8676002)(54356999)(50986999)(8746002)(50466002)(2906002)(11100500001)(4326007)(76176999)(102836003)(46406003)(7696003)(5003600100003)(97756001)(3846002)(81156014)(81166006)(23726003)(356003)(6116002)(8936002)(305945005)(87936001)(86362001)(110136002)(7736002)(33656002)(5250100002)(189998001)(106116001)(63266004)(106466001)(47776003)(2900100001)(2950100001)(2920100001)(7846002)(92566002)(55846006)(107986001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1NAM02HT203;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com;MX:1;A:1;CAT:NONE;LANG:en;CAT:NONE; |
| X-Ms-Office365-Filtering-Correlation-ID | 6c725306-0ca7-4c01-2247-08d3a7d41b2c |
| X-Microsoft-Antispam | UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:CY1NAM02HT203; |
| X-Microsoft-Antispam-Prvs | <0d7e5a1af8dc42bc930a437856821608@CY1NAM02HT203.eop-nam02.prod.protection.outlook.com> |
| X-Exchange-Antispam-Report-Test | UriScan:; |
| X-Exchange-Antispam-Report-Cfa-Test | BCL:0;PCL:0;RULEID:(601004)(2401047)(13018025)(13017025)(5005006)(8121501046)(13024025)(13023025)(13015025)(3002001)(10201501046)(6055026);SRVR:CY1NAM02HT203;BCL:0;PCL:0;RULEID:;SRVR:CY1NAM02HT203; |
| X-Forefront-Prvs | 0998671D02 |
| X-Originatororg | xilinx.com |
| X-Ms-Exchange-Crosstenant-Originalarrivaltime | 09 Jul 2016 08:36:21.2654 (UTC) |
| X-Ms-Exchange-Crosstenant-ID | 657af505-d5df-48d0-8300-c31994686c5c |
| X-Ms-Exchange-Crosstenant-Originalattributedtenantconnectingip | TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] |
| X-Ms-Exchange-Crosstenant-Fromentityheader | HybridOnPrem |
| X-Ms-Exchange-Transport-Crosstenantheadersstamped | CY1NAM02HT203 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 34 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | "robh+dt@kernel.org" <robh+dt@kernel.org>, "pawel.moll@arm.com" <pawel.moll@arm.com>, "mark.rutland@arm.com" <mark.rutland@arm.com>, "ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>, "galak@codeaurora.org" <galak@codeaurora.org>, Michal Simek <michals@xilinx.com>, Soren Brinkmann <sorenb@xilinx.com>, "dan.j.williams@intel.com" <dan.j.williams@intel.com>, "moritz.fischer@ettus.com" <moritz.fischer@ettus.com>, "laurent.pinchart@ideasonboard.com" <laurent.pinchart@ideasonboard.com>, "luis@debethencourt.com" <luis@debethencourt.com>, Punnaiah Choudary Kalluri <punnaia@xilinx.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org> |
| X-Original-Date | Sat, 9 Jul 2016 08:36:05 +0000 |
| X-Original-Message-ID | <C246CAC1457055469EF09E3A7AC4E11A4A5BC756@XAP-PVEXMBX01.xlnx.xilinx.com> |
| X-Original-References | <1467373026-27768-1-git-send-email-appanad@xilinx.com> <1467373026-27768-2-git-send-email-appanad@xilinx.com> <20160708055328.GP12591@localhost> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1439916 |
Show key headers only | View raw
Hi Vinod, Thanks for the review... > > + > > + chan->is_dmacoherent = of_property_read_bool(node, "dma- > coherent"); > > + zdev->chan = chan; > > + tasklet_init(&chan->tasklet, zynqmp_dma_do_tasklet, (ulong)chan); > > where is this killed? This is killed in the zynqmp_dma_chan_remove() API. > > > + spin_lock_init(&chan->lock); > > + INIT_LIST_HEAD(&chan->active_list); > > + INIT_LIST_HEAD(&chan->pending_list); > > + INIT_LIST_HEAD(&chan->done_list); > > + INIT_LIST_HEAD(&chan->free_list); > > + zynqmp_dma_init(chan); > > + chan->irq = platform_get_irq(pdev, 0); > > + if (chan->irq < 0) > > + return -ENXIO; > > + err = devm_request_irq(&pdev->dev, chan->irq, > zynqmp_dma_irq_handler, 0, > > + "zynqmp-dma", chan); > > this needs to be freed/diabled in remove, dont see that It is freed in the zynqmp_dma_chan_remove() API. Regards, Kedar.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v12 1/2] Documentation: DT: dma: Add Xilinx zynqmp dma device tree binding documentation Kedareswara rao Appana <appana.durga.rao@xilinx.com> - 2016-07-01 13:40 +0200
[PATCH v12 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support Kedareswara rao Appana <appana.durga.rao@xilinx.com> - 2016-07-01 13:40 +0200
Re: [PATCH v12 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support Vinod Koul <vinod.koul@intel.com> - 2016-07-08 07:50 +0200
RE: [PATCH v12 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support Appana Durga Kedareswara Rao <appana.durga.rao@xilinx.com> - 2016-07-09 10:40 +0200
Re: [PATCH v12 1/2] Documentation: DT: dma: Add Xilinx zynqmp dma device tree binding documentation Vinod Koul <vinod.koul@intel.com> - 2016-07-08 08:00 +0200
RE: [PATCH v12 1/2] Documentation: DT: dma: Add Xilinx zynqmp dma device tree binding documentation Appana Durga Kedareswara Rao <appana.durga.rao@xilinx.com> - 2016-07-09 10:10 +0200
csiph-web