Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1439714

Re: [PATCH 11/16] gpu: ipu-v3: Fix CSI data format for 16-bit media bus formats

From Philipp Zabel <p.zabel@pengutronix.de>
Newsgroups linux.kernel
Subject Re: [PATCH 11/16] gpu: ipu-v3: Fix CSI data format for 16-bit media bus formats
Date 2016-07-08 19:40 +0200
Message-ID <rSHUS-7Ss-37@gated-at.bofh.it> (permalink)
References <rSqAF-51z-3@gated-at.bofh.it> <rSqAF-51z-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam:
> The CSI data format was being programmed incorrectly for the
> 1x16 media bus formats. The CSI data format for 16-bit must
> be bayer/generic (CSI_SENS_CONF_DATA_FMT_BAYER).

I think this is not the case for BT.1120, but right now it that isn't
supported yet anyway.

> Suggested-by: Carsten Resch <Carsten.Resch@de.bosch.com>
> Signed-off-by: Steve Longerbeam <steve_longerbeam@mentor.com>
> ---
>  drivers/gpu/ipu-v3/ipu-csi.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/ipu-v3/ipu-csi.c b/drivers/gpu/ipu-v3/ipu-csi.c
> index 07c7091..0eac28c 100644
> --- a/drivers/gpu/ipu-v3/ipu-csi.c
> +++ b/drivers/gpu/ipu-v3/ipu-csi.c
> @@ -258,12 +258,8 @@ static int mbus_code_to_bus_cfg(struct ipu_csi_bus_config *cfg, u32 mbus_code)
>  		cfg->data_width = IPU_CSI_DATA_WIDTH_8;
>  		break;
>  	case MEDIA_BUS_FMT_UYVY8_1X16:
> -		cfg->data_fmt = CSI_SENS_CONF_DATA_FMT_YUV422_UYVY;
> -		cfg->mipi_dt = MIPI_DT_YUV422;
> -		cfg->data_width = IPU_CSI_DATA_WIDTH_16;
> -		break;
>  	case MEDIA_BUS_FMT_YUYV8_1X16:
> -		cfg->data_fmt = CSI_SENS_CONF_DATA_FMT_YUV422_YUYV;
> +		cfg->data_fmt = CSI_SENS_CONF_DATA_FMT_BAYER;
>  		cfg->mipi_dt = MIPI_DT_YUV422;
>  		cfg->data_width = IPU_CSI_DATA_WIDTH_16;
>  		break;

regards
Philipp

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 11/16] gpu: ipu-v3: Fix CSI data format for 16-bit media bus formats Steve Longerbeam <slongerbeam@gmail.com> - 2016-07-08 01:10 +0200
  Re: [PATCH 11/16] gpu: ipu-v3: Fix CSI data format for 16-bit media  bus formats Philipp Zabel <p.zabel@pengutronix.de> - 2016-07-08 19:40 +0200

csiph-web