[PATCH] bnxt_en: initialize rc to zero to avoid returning garbage

From	Colin King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	[PATCH] bnxt_en: initialize rc to zero to avoid returning garbage
Date	2016-07-08 17:50 +0200
Message-ID	<rSGcq-6ES-31@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

rc is not initialized so it can contain garbage if it is not
set by the call to bnxt_read_sfp_module_eeprom_info. Ensure
garbage is not returned by initializing rc to 0.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
index 0f7dd86..64466f5 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
@@ -1684,7 +1684,7 @@ static int bnxt_get_module_eeprom(struct net_device *dev,
 {
 	struct bnxt *bp = netdev_priv(dev);
 	u16  start = eeprom->offset, length = eeprom->len;
-	int rc;
+	int rc = 0;
 
 	memset(data, 0, eeprom->len);
 
-- 
2.8.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] bnxt_en: initialize rc to zero to avoid returning garbage Colin King <colin.king@canonical.com> - 2016-07-08 17:50 +0200
  Re: [PATCH] bnxt_en: initialize rc to zero to avoid returning garbage Michael Chan <michael.chan@broadcom.com> - 2016-07-08 22:10 +0200
  Re: [PATCH] bnxt_en: initialize rc to zero to avoid returning  garbage David Miller <davem@davemloft.net> - 2016-07-11 21:50 +0200

csiph-web