Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1439571

Re: [PATCH v8 5/6] arm64: add support for ACPI Low Power Idle(LPI)

Show all headers | View raw

On 08/07/16 15:47, Lorenzo Pieralisi wrote:
> On Thu, Jul 07, 2016 at 06:10:50PM +0100, Sudeep Holla wrote:
>> This patch adds appropriate callbacks to support ACPI Low Power Idle
>> (LPI) on ARM64.
>>
>> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>> Cc: Mark Rutland <mark.rutland@arm.com>
>> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
>> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>> ---
>>   arch/arm64/kernel/cpuidle.c |  18 +++++++
>>   drivers/firmware/psci.c     | 122 ++++++++++++++++++++++++++++++++++++--------
>
> I would split this patch in two (ARM64 cpuidle and PSCI)

Agreed, I combined it to get it functional in one go, but until we have
6/6, it won't work. So better to split that changes.

> and for
> the PSCI code (apologies, blame taken, it is entirely my fault) I
> think that the code in v6 was better, I asked you to factor out
> DT/ACPI idle states count and parameter retrieval but the end result
> is much more complicated than what it was in v6, so for PSCI ACPI
> idle states parsing I would revert to v6, apologies.
>

Yes I agree it got bit complicated. I will revert back to v6 for that part.


> With changes above:
>
> Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>

Thanks

-- 
Regards,
Sudeep

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v8 0/6] ACPI / processor_idle: Add ACPI v6.0 LPI support Sudeep Holla <sudeep.holla@arm.com> - 2016-07-07 19:20 +0200
  [PATCH v8 1/6] ACPI / processor_idle: introduce ACPI_PROCESSOR_CSTATE Sudeep Holla <sudeep.holla@arm.com> - 2016-07-07 19:20 +0200
    [PATCH v8 3/6] arm64: cpuidle: drop __init section marker to arm_cpuidle_init Sudeep Holla <sudeep.holla@arm.com> - 2016-07-07 19:20 +0200
      [PATCH v8 4/6] cpuidle: introduce CPU_IDLE_ENTER_WRAPPED macro for ARM{32,64} Sudeep Holla <sudeep.holla@arm.com> - 2016-07-07 19:20 +0200
        [PATCH v8 5/6] arm64: add support for ACPI Low Power Idle(LPI) Sudeep Holla <sudeep.holla@arm.com> - 2016-07-07 19:20 +0200
          [PATCH v8 6/6] ACPI : enable ACPI_PROCESSOR_IDLE on ARM64 Sudeep Holla <sudeep.holla@arm.com> - 2016-07-07 19:20 +0200
          Re: [PATCH v8 5/6] arm64: add support for ACPI Low Power Idle(LPI) Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-07-08 16:50 +0200
            Re: [PATCH v8 5/6] arm64: add support for ACPI Low Power Idle(LPI) Sudeep Holla <sudeep.holla@arm.com> - 2016-07-08 17:30 +0200
    [PATCH v8 2/6] ACPI / processor_idle: Add support for Low Power Idle(LPI) states Sudeep Holla <sudeep.holla@arm.com> - 2016-07-07 19:20 +0200
  Re: [PATCH v8 0/6] ACPI / processor_idle: Add ACPI v6.0 LPI support "Rafael J. Wysocki" <rafael@kernel.org> - 2016-07-07 23:10 +0200
    Re: [PATCH v8 0/6] ACPI / processor_idle: Add ACPI v6.0 LPI support Sudeep Holla <sudeep.holla@arm.com> - 2016-07-08 13:10 +0200
      Re: [PATCH v8 0/6] ACPI / processor_idle: Add ACPI v6.0 LPI support Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-07-08 16:50 +0200
        Re: [PATCH v8 0/6] ACPI / processor_idle: Add ACPI v6.0 LPI support Sudeep Holla <sudeep.holla@arm.com> - 2016-07-08 17:30 +0200

csiph-web