Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1439440

Re: [PATCH 1/4] spi: s3c64xx: rename goto labels to meaningful names

From Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/4] spi: s3c64xx: rename goto labels to meaningful names
Date 2016-07-08 15:20 +0200
Message-ID <rSDRf-5g5-5@gated-at.bofh.it> (permalink)
References <rSCVb-4Fq-11@gated-at.bofh.it> <rSCVb-4Fq-13@gated-at.bofh.it> <rSDRf-5g5-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 07/08/2016 03:11 PM, Krzysztof Kozlowski wrote:
> On 07/08/2016 02:18 PM, Andi Shyti wrote:
>> In goto labels of the style of
> 
> s/In/The/
> 
>>
>>   err4:
>>   err3:
>>   err2:
>>   err1:
>>
>> is complex to insert in between new errors without renaming all
> 
> s/is/are/ (or just rewrite it... "The style of such goto labels... is")
> 
>> the goto statments. Replace the errX naming style to meaningful
> 
> s/statments/satements/

Yeah, nice job (to me)... error in error correction. Of course
"statements"...

BR,
Krzysztof

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/4] spi: s3c64xx: rename goto labels to meaningful names Andi Shyti <andi.shyti@samsung.com> - 2016-07-08 14:20 +0200
  Re: [PATCH 1/4] spi: s3c64xx: rename goto labels to meaningful names Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-07-08 15:20 +0200
  Re: [PATCH 1/4] spi: s3c64xx: rename goto labels to meaningful names Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-07-08 15:20 +0200

csiph-web