[PATCH 14/20] iommu/amd: Implement timeout to flush unmap queues

Path	csiph.com!feeder.erje.net!1.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!weretis.net!feeder4.news.weretis.net!storethat.news.telefonica.de!telefonica.de!news.panservice.it!bofh.it!news.nic.it!robomod
From	Joerg Roedel <joro@8bytes.org>
Newsgroups	linux.kernel
Subject	[PATCH 14/20] iommu/amd: Implement timeout to flush unmap queues
Date	Fri, 08 Jul 2016 13:50:01 +0200
Message-ID	<rSCs9-4e3-15@gated-at.bofh.it> (permalink)
References	<rSCs9-4e3-3@gated-at.bofh.it>
X-Original-To	iommu@lists.linux-foundation.org
Dkim-Signature	v=1; a=rsa-sha256; c=simple/simple; d=8bytes.org; s=mail-1; t=1467978325; bh=dOrm60ZFy3Ycidq8wy60H79YxeGBcUfWkKFt7fdoKWM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Rte1i8G/PXvhLFm9TFWQ6yYl+vn0dQ/4hKbLI7FwOEKlpjNAvCVsJYxPveRFViLiK bt4Nal+HEEMTRAx/qME/0DyxTJE4fwYKIW4oYTcAEqKCJp2/GlAYOxae8lqu4Xcwun NZIGM6G/OyduDG9A03B2oIQaG2DgvXMLqLeoBO+bWMVNE2ifHOxC0h/49GOiERiDZK 04EtkBChI4FbHrale9uvOcpSilLMebQAabvYtVEYzphGSfGkSm9fawiV3i6jDwoyWo Oue6IOqduzw5cWmClMcVSBTxPprDgB8kjNepun4l1IxbYvWjLRYifz0TLby5urh9XK RwTX++3Vxdlpg==
X-Mailer	git-send-email 1.9.1
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	73
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>, Vincent.Wan@amd.com, Joerg Roedel <jroedel@suse.de>
X-Original-Date	Fri, 8 Jul 2016 13:45:05 +0200
X-Original-Message-ID	<1467978311-28322-15-git-send-email-joro@8bytes.org>
X-Original-References	<1467978311-28322-1-git-send-email-joro@8bytes.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1439336

Show key headers only | View raw

From: Joerg Roedel <jroedel@suse.de>

In case the queue doesn't fill up, we flush the TLB at least
10ms after the unmap happened to make sure that the TLB is
cleaned up.

Signed-off-by: Joerg Roedel <jroedel@suse.de>
---
 drivers/iommu/amd_iommu.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index a3e09cd..1bb003e 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -104,6 +104,9 @@ struct flush_queue {
 
 DEFINE_PER_CPU(struct flush_queue, flush_queue);
 
+static atomic_t queue_timer_on;
+static struct timer_list queue_timer;
+
 /*
  * Domain for untranslated devices - only allocated
  * if iommu=pt passed on kernel cmd line.
@@ -2159,6 +2162,24 @@ static void __queue_flush(struct flush_queue *queue)
 	queue->next = 0;
 }
 
+void queue_flush_timeout(unsigned long unsused)
+{
+	int cpu;
+
+	atomic_set(&queue_timer_on, 0);
+
+	for_each_possible_cpu(cpu) {
+		struct flush_queue *queue;
+		unsigned long flags;
+
+		queue = per_cpu_ptr(&flush_queue, cpu);
+		spin_lock_irqsave(&queue->lock, flags);
+		if (queue->next > 0)
+			__queue_flush(queue);
+		spin_unlock_irqrestore(&queue->lock, flags);
+	}
+}
+
 static void queue_add(struct dma_ops_domain *dma_dom,
 		      unsigned long address, unsigned long pages)
 {
@@ -2184,6 +2205,10 @@ static void queue_add(struct dma_ops_domain *dma_dom,
 	entry->dma_dom  = dma_dom;
 
 	spin_unlock_irqrestore(&queue->lock, flags);
+
+	if (atomic_cmpxchg(&queue_timer_on, 0, 1) == 0)
+		mod_timer(&queue_timer, jiffies + msecs_to_jiffies(10));
+
 	put_cpu_ptr(&flush_queue);
 }
 
@@ -2639,6 +2664,9 @@ out_put_iova:
 
 int __init amd_iommu_init_dma_ops(void)
 {
+	setup_timer(&queue_timer, queue_flush_timeout, 0);
+	atomic_set(&queue_timer_on, 0);
+
 	swiotlb        = iommu_pass_through ? 1 : 0;
 	iommu_detected = 1;
 
-- 
1.9.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 14/20] iommu/amd: Implement timeout to flush unmap queues Joerg Roedel <joro@8bytes.org> - 2016-07-08 13:50 +0200

csiph-web