[PATCH 1/1] Tools: hv: kvp: ensure kvp device fd is closed on exec

From	kys@exchange.microsoft.com
Newsgroups	linux.kernel
Subject	[PATCH 1/1] Tools: hv: kvp: ensure kvp device fd is closed on exec
Date	2016-07-07 01:50 +0200
Message-ID	<rS4JP-7qj-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Vitaly Kuznetsov <vkuznets@redhat.com>

KVP daemon does fork()/exec() (with popen()) so we need to close our fds
to avoid sharing them with child processes. The immediate implication of
not doing so I see is SELinux complaining about 'ip' trying to access
'/dev/vmbus/hv_kvp'.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
 tools/hv/hv_kvp_daemon.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
index 0d9f48e..bc7adb8 100644
--- a/tools/hv/hv_kvp_daemon.c
+++ b/tools/hv/hv_kvp_daemon.c
@@ -1433,7 +1433,7 @@ int main(int argc, char *argv[])
 	openlog("KVP", 0, LOG_USER);
 	syslog(LOG_INFO, "KVP starting; pid is:%d", getpid());
 
-	kvp_fd = open("/dev/vmbus/hv_kvp", O_RDWR);
+	kvp_fd = open("/dev/vmbus/hv_kvp", O_RDWR | O_CLOEXEC);
 
 	if (kvp_fd < 0) {
 		syslog(LOG_ERR, "open /dev/vmbus/hv_kvp failed; error: %d %s",
-- 
1.7.4.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 1/1] Tools: hv: kvp: ensure kvp device fd is closed on exec kys@exchange.microsoft.com - 2016-07-07 01:50 +0200

csiph-web