Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1436881

Re: [PATCH v2 8/8] Input: synaptics-rmi4: Use the RMI_F11_REL_BYTES define in rmi_f11_rel_pos_report

Show all headers | View raw

On 25/06/2016 01:19, Andrew Duggan wrote:
> The size of relative data in F11 is already defined by RMI_F11_REL_BYTES.
> Use the define in rmi_f11_rel_pos_report() to be consistent.
> 
> Signed-off-by: Andrew Duggan <aduggan@synaptics.com>

Reviewed-by: Nick Dyer <nick@shmanahar.org>

> ---
>  drivers/input/rmi4/rmi_f11.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c
> index 3fda75b..cce82a1 100644
> --- a/drivers/input/rmi4/rmi_f11.c
> +++ b/drivers/input/rmi4/rmi_f11.c
> @@ -530,8 +530,8 @@ static void rmi_f11_rel_pos_report(struct f11_data *f11, u8 n_finger)
>  	struct f11_2d_data *data = &f11->data;
>  	s8 x, y;
>  
> -	x = data->rel_pos[n_finger * 2];
> -	y = data->rel_pos[n_finger * 2 + 1];
> +	x = data->rel_pos[n_finger * RMI_F11_REL_BYTES];
> +	y = data->rel_pos[n_finger * RMI_F11_REL_BYTES + 1];
>  
>  	rmi_2d_sensor_rel_report(sensor, x, y);
>  }
> 

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 8/8] Input: synaptics-rmi4: Use the RMI_F11_REL_BYTES define in rmi_f11_rel_pos_report Andrew Duggan <aduggan@synaptics.com> - 2016-06-25 02:30 +0200
  Re: [PATCH v2 8/8] Input: synaptics-rmi4: Use the RMI_F11_REL_BYTES  define in rmi_f11_rel_pos_report Nick Dyer <nick.dyer@itdev.co.uk> - 2016-07-05 12:10 +0200

csiph-web