Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1436820
| From | Wan Zongshun <vw@iommu.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/6] Clocksource: add nuc970 clocksource driver |
| Date | 2016-07-05 09:50 +0200 |
| Message-ID | <rRthg-8dT-3@gated-at.bofh.it> (permalink) |
| References | <rNTah-4kz-7@gated-at.bofh.it> <rNTaj-4kz-51@gated-at.bofh.it> <rPpB7-5RI-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 2016年06月29日 23:25, Arnd Bergmann wrote:
> On Saturday, June 25, 2016 6:37:19 PM CEST Wan Zongshun wrote:
>> This patch is to add nuc970 clocksource driver support.
>>
>> Signed-off-by: Wan Zongshun <mcuos.com@gmail.com>
>> ---
>> .../mach-w90x900/include/mach/nuc970-regs-timer.h | 44 +++++
>> drivers/clocksource/Kconfig | 8 +
>> drivers/clocksource/Makefile | 1 +
>> drivers/clocksource/timer-nuc900.c | 207 +++++++++++++++++++++
>> 4 files changed, 260 insertions(+)
>> create mode 100644 arch/arm/mach-w90x900/include/mach/nuc970-regs-timer.h
>> create mode 100644 drivers/clocksource/timer-nuc900.c
>>
>> diff --git a/arch/arm/mach-w90x900/include/mach/nuc970-regs-timer.h b/arch/arm/mach-w90x900/include/mach/nuc970-regs-timer.h
>> new file mode 100644
>> index 0000000..43d7e8b
>> --- /dev/null
>> +++ b/arch/arm/mach-w90x900/include/mach/nuc970-regs-timer.h
>
> Please move the contents of the header file into the driver. We try to not
> have any new mach/*.h headers.
Ok, done.
>
>> +
>> +static unsigned int timer0_load;
>> +static void __iomem *tmr_base;
>> +
>> +static int nuc970_clockevent_set_oneshot(struct clock_event_device *evt)
>> +{
>> + unsigned int val;
>> +
>> + val = __raw_readl(tmr_base + REG_TMR_TCSR0);
>> + val &= ~(0x03 << 27);
>> +
>> + val |= (ONESHOT | COUNTEN | INTEN | PRESCALE);
>> +
>> + __raw_writel(val, tmr_base + REG_TMR_TCSR0);
>> + return 0;
>> +}
>> +
>
> writel() instead of __raw_writel()
Ok, so this change will apply to all drivers.
>
> Arnd
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
>
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH 3/6] Clocksource: add nuc970 clocksource driver Wan Zongshun <vw@iommu.org> - 2016-06-25 12:40 +0200
Re: [PATCH 3/6] Clocksource: add nuc970 clocksource driver Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-27 21:50 +0200
Re: [PATCH 3/6] Clocksource: add nuc970 clocksource driver Wan Zongshun <vw@iommu.org> - 2016-07-05 10:30 +0200
Re: [PATCH 3/6] Clocksource: add nuc970 clocksource driver Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-07-05 12:10 +0200
Re: [PATCH 3/6] Clocksource: add nuc970 clocksource driver Arnd Bergmann <arnd@arndb.de> - 2016-06-29 17:30 +0200
Re: [PATCH 3/6] Clocksource: add nuc970 clocksource driver Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-29 18:20 +0200
Re: [PATCH 3/6] Clocksource: add nuc970 clocksource driver Wan Zongshun <vw@iommu.org> - 2016-07-05 09:50 +0200
csiph-web