Re: [PATCH 2/4] perf tools: Do the error path hist_entry release in hist_entry__new

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/4] perf tools: Do the error path hist_entry release in hist_entry__new
Date	2016-07-05 08:40 +0200
Message-ID	<rRsbv-7C5-9@gated-at.bofh.it> (permalink)
References	<rRcJs-6B7-21@gated-at.bofh.it> <rRcJs-6B7-31@gated-at.bofh.it> <rRhpL-116-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jul 04, 2016 at 04:09:47PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Jul 04, 2016 at 04:01:37PM +0200, Jiri Olsa escreveu:
> > It's better to release the hist_entry object in
> > hist_entry__new function (where it's allocated)
> > rather than in hist_entry__init.
> 
> Please combine this with the previous patch, that way this all gets
> clearer :-\

ok, will change

thanks,
jirka

Thread

[RFC 0/4] perf tools: Add hist_entry allocation callbacks Jiri Olsa <jolsa@kernel.org> - 2016-07-04 16:10 +0200
  [PATCH 1/4] perf tools: Introduce hist_entry__init function Jiri Olsa <jolsa@kernel.org> - 2016-07-04 16:10 +0200
    Re: [PATCH 1/4] perf tools: Introduce hist_entry__init function Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-07-04 21:10 +0200
  [PATCH 2/4] perf tools: Do the error path hist_entry release in hist_entry__new Jiri Olsa <jolsa@kernel.org> - 2016-07-04 16:10 +0200
    Re: [PATCH 2/4] perf tools: Do the error path hist_entry release in  hist_entry__new Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-07-04 21:10 +0200
      Re: [PATCH 2/4] perf tools: Do the error path hist_entry release in  hist_entry__new Jiri Olsa <jolsa@redhat.com> - 2016-07-05 08:40 +0200
  [PATCH 3/4] perf tools: Introduce hist_entry_ops Jiri Olsa <jolsa@kernel.org> - 2016-07-04 16:10 +0200
  [PATCH 4/4] perf tools: Introduce hists__add_entry_ops function Jiri Olsa <jolsa@kernel.org> - 2016-07-04 16:10 +0200

csiph-web