Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1436787
| From | Jiri Olsa <jolsa@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/4] perf tools: Add initialized arg into unwind__prepare_access |
| Date | 2016-07-05 08:30 +0200 |
| Message-ID | <rRs1P-7yT-1@gated-at.bofh.it> (permalink) |
| References | <rRb0Z-5uY-9@gated-at.bofh.it> <rRb0Z-5uY-15@gated-at.bofh.it> <rRhJ7-17F-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Jul 04, 2016 at 04:25:11PM -0300, Arnaldo Carvalho de Melo wrote:
SNIP
> > }
> > @@ -67,7 +69,8 @@ unwind__get_entries(unwind_entry_cb_t cb __maybe_unused,
> > }
> >
> > static inline int unwind__prepare_access(struct thread *thread __maybe_unused,
> > - struct map *map __maybe_unused)
> > + struct map *map __maybe_unused,
> > + bool *initialized __maybe_unused);
> > {
> > return 0;
> > }
>
> That extra ; breaks the build on centos5 (i.e. on an arch where the
> above code gets compiled:
>
> CC /tmp/build/perf/bench/sched-pipe.o
> In file included from util/machine.c:14:
> util/unwind.h:74: error: expected identifier or '(' before '{' token
> MKDIR /tmp/build/perf/tests/
> CC /tmp/build/perf/tests/parse-events.o
> mv: cannot stat `/tmp/build/perf/util/.machine.o.tmp': No such file or directory
> make[3]: *** [/tmp/build/perf/util/machine.o] Error 1
> make[3]: *** Waiting for unfinished jobs....
> MKDIR /tmp/build/perf/tests/
> CC /tmp/build/perf/tests/dso-data.o
> make[2]: *** [util] Error 2
> make[1]: *** [/tmp/build/perf/libperf-in.o] Error 2
> make[1]: *** Waiting for unfinished jobs....
> MKDIR /tmp/build/perf/tests/
>
>
> Fixing it.
oops, thanks
jirka
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 3/4] perf tools: Add initialized arg into unwind__prepare_access Jiri Olsa <jolsa@kernel.org> - 2016-07-04 14:20 +0200
Re: [PATCH 3/4] perf tools: Add initialized arg into unwind__prepare_access Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-07-04 21:30 +0200
Re: [PATCH 3/4] perf tools: Add initialized arg into unwind__prepare_access Jiri Olsa <jolsa@redhat.com> - 2016-07-05 08:30 +0200
[tip:perf/core] perf unwind: Add initialized arg into unwind__prepare_access tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-07-05 12:30 +0200
csiph-web