Re: [PATCH] fsl/fman: fix error handling

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] fsl/fman: fix error handling
Date	2016-07-05 02:20 +0200
Message-ID	<rRmfM-3Zm-17@gated-at.bofh.it> (permalink)
References	<rR4Vz-1HH-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Date: Mon,  4 Jul 2016 07:46:42 +0200

> This is likely that checking 'fman->fifo_offset' instead of
> 'fman->cam_offset' is expected here.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> 
> The type of 'fifo_offset' may also need to be changed.

Fix the test rather than trying to force it into the error pointer
macro.

If fifo_offset is not a pointer, then change the test to check for
whatever would be appropriate for values returned from
fman_muram_alloc().

This is a very low quality patch submission, you submitted a "fix"
which added a new build warning and made it obvious that something
else is needed as well here.  You even stated that you realized this.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] fsl/fman: fix error handling Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-07-04 07:50 +0200
  Re: [PATCH] fsl/fman: fix error handling David Miller <davem@davemloft.net> - 2016-07-05 02:20 +0200

csiph-web