Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1436582

Re: [PATCH] vfs: fix typo in link_path_walk()

From Omar Sandoval <osandov@osandov.com>
Newsgroups linux.kernel
Subject Re: [PATCH] vfs: fix typo in link_path_walk()
Date 2016-07-04 22:20 +0200
Message-ID <rRivv-1HR-1@gated-at.bofh.it> (permalink)
References <rRfei-7YV-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Jul 04, 2016 at 05:48:53PM +0100, Luis de Bethencourt wrote:
> Comment documenting the path parsing in link_path_walk() has a typo, fixing
> it.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
> 
> Hello,
> 
> Noticed this typo while studying the code paths when sys_open is called.
> 
> Thanks,
> Luis
> 
>  fs/namei.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/namei.c b/fs/namei.c
> index 32f9fe9..ade7667 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -2064,7 +2064,7 @@ static int link_path_walk(const char *name, struct nameidata *nd)
>  		if (!*name)
>  			goto OK;
>  		/*
> -		 * If it wasn't NUL, we know it was '/'. Skip that
> +		 * If it wasn't NULL, we know it was '/'. Skip that
>  		 * slash, and continue until no more slashes.
>  		 */
>  		do {
> -- 
> 2.6.4

NUL is the ASCII '\0' character. NULL is a pointer. So NUL is correct.

-- 
Omar

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] vfs: fix typo in link_path_walk() Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-07-04 18:50 +0200
  Re: [PATCH] vfs: fix typo in link_path_walk() Omar Sandoval <osandov@osandov.com> - 2016-07-04 22:20 +0200
  Re: [PATCH] vfs: fix typo in link_path_walk() Al Viro <viro@ZenIV.linux.org.uk> - 2016-07-04 23:00 +0200
    Re: [PATCH] vfs: fix typo in link_path_walk() Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-07-05 15:40 +0200

csiph-web