Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1436461

Re: [PATCH 04/14] PCI: generic: make it explicitly non-modular

Show all headers | View raw

On Sat, Jul 02, 2016 at 07:13:24PM -0400, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
> drivers/pci/host/Kconfig:config PCI_HOST_GENERIC
> drivers/pci/host/Kconfig:       bool "Generic PCI host controller"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the few trace uses of modular code and macros, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
> 
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.

Ideally, we'd simply fix this to build as a module, but it's not clear
how to do that now that the ecam accessors have been split out into
their own file. A liberal sprinkling of EXPORT_SYMBOL might work, but
it's a bit grotty.

David, Jayachandran -- do you have any desire to build your PCI host
controller drivers as modules?

Will

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 04/14] PCI: generic: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-03 01:20 +0200
  Re: [PATCH 04/14] PCI: generic: make it explicitly non-modular Will Deacon <will.deacon@arm.com> - 2016-07-04 19:40 +0200
    Re: [PATCH 04/14] PCI: generic: make it explicitly non-modular Jayachandran C <jchandra@broadcom.com> - 2016-07-06 06:30 +0200
  Re: [PATCH 04/14] PCI: generic: make it explicitly non-modular Will Deacon <will.deacon@arm.com> - 2016-07-06 19:10 +0200
    Re: [PATCH 04/14] PCI: generic: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-06 19:50 +0200

csiph-web