Re: [PATCH -next] orangefs: use vzalloc() instead of vmalloc()/memset(0)

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH -next] orangefs: use vzalloc() instead of vmalloc()/memset(0)
Date	Wed, 06 Jul 2016 20:20:01 +0200
Message-ID	<rRZAt-4ax-1@gated-at.bofh.it> (permalink)
References	<rRV3P-1jb-15@gated-at.bofh.it> <rRYO5-3Ee-7@gated-at.bofh.it> <rRZ7s-3Lq-3@gated-at.bofh.it> <rRZqO-47a-23@gated-at.bofh.it>
X-Original-To	Mike Marshall <hubcap@omnibond.com>
X-Session-Marker	6A6F6540706572636865732E636F6D
X-Spam-Summary	2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2110:2393:2559:2562:2828:2899:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3874:4250:4321:5007:10004:10400:10848:11232:11658:11914:12517:12519:12740:13069:13071:13095:13161:13229:13311:13357:13439:13618:14180:14181:14659:21060:21080:21433,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none
X-He-Tag	sun51_639bf829e7218
X-Filterd-Recvd-Size	1704
Content-Type	text/plain; charset="ISO-8859-1"
X-Mailer	Evolution 3.18.5.2-0ubuntu3
MIME-Version	1.0
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	23
Organization	linux.* mail to news gateway
X-Original-Cc	weiyj_lk@163.com, Wei Yongjun <yongjun_wei@trendmicro.com.cn>, LKML <linux-kernel@vger.kernel.org>
X-Original-Date	Wed, 06 Jul 2016 11:11:23 -0700
X-Original-Message-ID	<1467828683.8360.36.camel@perches.com>
X-Original-References	<1467811431-2535-1-git-send-email-weiyj_lk@163.com> <CAOg9mSStropnZ2LiOFgF6t1Tm3YBeR6eEE8d6m=+wORBVh8ugA@mail.gmail.com> <1467827385.8360.30.camel@perches.com> <CAOg9mSSUe+u7kYAkD-Z8qCrf99Q+1-=tLf0=gtNmPBSe+U=nsA@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1437896

Show key headers only | View raw

On Wed, 2016-07-06 at 14:00 -0400, Mike Marshall wrote:
> Hi Joe...

Hi Mike.

> I looked around at other code to see how they were using vzalloc...
> even if it is just the caller of the function that uses vzalloc, most
> fs's that use vzalloc print an error message when vzalloc fails...

That's incorrect.

There are 72 v.alloc calls in fs/
2 of those calls have a specific OOM message.
There's 1 in reiserfs (old and unsupported) and 1 in orangefs

>  I sure do
> like to follow the flow of our kernel module all in one place
> with the gossip statements...

I don't see how that matters here as there's
already an OOM on v.alloc failure.

cheers, Joe

Thread

[PATCH -next] orangefs: use vzalloc() instead of vmalloc()/memset(0) weiyj_lk@163.com - 2016-07-06 15:30 +0200
  Re: [PATCH -next] orangefs: use vzalloc() instead of vmalloc()/memset(0) Mike Marshall <hubcap@omnibond.com> - 2016-07-06 19:30 +0200
    Re: [PATCH -next] orangefs: use vzalloc() instead of  vmalloc()/memset(0) Joe Perches <joe@perches.com> - 2016-07-06 19:50 +0200
      Re: [PATCH -next] orangefs: use vzalloc() instead of vmalloc()/memset(0) Mike Marshall <hubcap@omnibond.com> - 2016-07-06 20:10 +0200
        Re: [PATCH -next] orangefs: use vzalloc() instead of  vmalloc()/memset(0) Joe Perches <joe@perches.com> - 2016-07-06 20:20 +0200
          Re: [PATCH -next] orangefs: use vzalloc() instead of vmalloc()/memset(0) Mike Marshall <hubcap@omnibond.com> - 2016-07-06 21:10 +0200

csiph-web