Re: [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

From	Emil Velikov <emil.l.velikov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel
Date	2016-07-06 19:20 +0200
Message-ID	<rRYEp-3A0-3@gated-at.bofh.it> (permalink)
References	<rM0pz-4g5-3@gated-at.bofh.it> <rM0pz-4g5-9@gated-at.bofh.it> <rP3AB-ys-1@gated-at.bofh.it> <rQYwN-68C-3@gated-at.bofh.it> <rR5yh-2a2-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 4 July 2016 at 07:27, Vinay Simha <simhavcs@gmail.com> wrote:
> On Mon, Jul 4, 2016 at 4:22 AM, Emil Velikov <emil.l.velikov@gmail.com> wrote:
>> On 28 June 2016 at 16:59, Vinay Simha <simhavcs@gmail.com> wrote:
>>> hi,
>>>
>>> Any further comments or reviews?
>>>
>> You still haven't covered my earlier suggestions, as such I cannot
>> give you a r-b :-( They are not blockers by any means, but it'll be
>> up-to the maintainer to ack/pick this up.
> i do have covered the suggestions from you.
> As i had mentioned earlier we cannot drop few returns and keep it
> void(drm_panel_funcs - unprepare), since drm framework requires
> return. if do you have any alternate solution please suggest, will
> incorporate.
Please re-read what I said. I don't recall suggesting changes to the
vfunc signature but the helper that you're calling. Why ? Because it's
uncommon/unwise to prematurely exit during the teardown/destructor
stage.

Although as said previously, its nothing serious, hence why people
rarely bother.
-Emil

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel Vinay Simha <simhavcs@gmail.com> - 2016-06-28 18:00 +0200
  Re: [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel Emil Velikov <emil.l.velikov@gmail.com> - 2016-07-04 01:00 +0200
    Re: [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel Vinay Simha <simhavcs@gmail.com> - 2016-07-04 08:30 +0200
      Re: [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel Emil Velikov <emil.l.velikov@gmail.com> - 2016-07-06 19:20 +0200

csiph-web