Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1437786
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: Re: cgroup: Fix split bio been throttled more than once |
| Date | 2016-07-06 17:10 +0200 |
| Message-ID | <rRWCB-2lt-17@gated-at.bofh.it> (permalink) |
| References | <rRdFv-7cY-5@gated-at.bofh.it> <rRHke-DO-43@gated-at.bofh.it> <rRWCB-2lt-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hello, On Wed, Jul 06, 2016 at 10:58:55PM +0800, aaronlee0817 wrote: > >But that said, can't we just copy BIO_THROTLED while splitting? > > In my opinion， copying BIO_THROTLED while splitting doesn't work > with this, because, the bio within the limit will not set BIO_THROTLED > but will be split, and back to call generic_make_request(), and will be > count twice. I see. It's just a bit weird that we're marking this from clone site when it's an issue which is specific to throttling. The thing is depending on how bio clone is used, it could misbehave in the other direction (bio not accounted at all). What we want to know is whether a bio has been previously accounted or not, rather than whether a bio is a result of splitting. I think it'd be better to track that instead. Thanks. -- tejun
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
cgroup: Fix split bio been throttled more than once "Jiale Li" <aaronlee0817@163.com> - 2016-07-04 17:10 +0200
Re: cgroup: Fix split bio been throttled more than once Tejun Heo <tj@kernel.org> - 2016-07-06 00:50 +0200
Re: cgroup: Fix split bio been throttled more than once Ming Lei <tom.leiming@gmail.com> - 2016-07-06 03:20 +0200
Re: Re: cgroup: Fix split bio been throttled more than once Tejun Heo <tj@kernel.org> - 2016-07-06 17:10 +0200
Re: Re: cgroup: Fix split bio been throttled more than once Ming Lei <tom.leiming@gmail.com> - 2016-07-06 17:40 +0200
Re: cgroup: Fix split bio been throttled more than once Ming Lei <tom.leiming@gmail.com> - 2016-07-06 03:20 +0200
Re: cgroup: Fix split bio been throttled more than once Tejun Heo <tj@kernel.org> - 2016-07-06 16:10 +0200
Re: cgroup: Fix split bio been throttled more than once Ming Lei <tom.leiming@gmail.com> - 2016-07-06 17:00 +0200
Re: Re: cgroup: Fix split bio been throttled more than once Ming Lei <tom.leiming@gmail.com> - 2016-07-08 12:40 +0200
Re: Re: cgroup: Fix split bio been throttled more than once Tejun Heo <tj@kernel.org> - 2016-07-09 17:00 +0200
csiph-web