Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1437726

Re: [PATCH -next] memory: atmel-ebi: use PTR_ERR_OR_ZERO() to simplify the code

Show all headers | View raw

On 06/07/2016 at 21:19:34 +0800, Wei Yongjun wrote :
> Hi,
> 
> On 07/06/2016 08:18 PM, Alexandre Belloni wrote:
> > Hi,
> >
> > On 06/07/2016 at 12:08:05 +0000, weiyj_lk@163.com wrote :
> >> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> >>
> >> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR.
> >>
> > I'm guessing you found that using coccinnelle or any other static
> > analysis tool. Can you mention that in the commit message?
> >
> Your are right, this patch is found by coccinelle and created by scripts.
> (I called it dpatch, a kernel patch IDE, which had integrated coccinelle,
> sparse engine, scripts to found and create kernel patch.
> REF: https://github.com/weiyj/dpatch-devel).
> 
> I mentioned those in passed, but no all of people like this.
> 

Well it helps knowing whether this has been tested on actual hardware or
not.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH -next] memory: atmel-ebi: use PTR_ERR_OR_ZERO() to simplify the code weiyj_lk@163.com - 2016-07-06 14:10 +0200
  Re: [PATCH -next] memory: atmel-ebi: use PTR_ERR_OR_ZERO() to  simplify the code Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-07-06 14:20 +0200
    Re: [PATCH -next] memory: atmel-ebi: use PTR_ERR_OR_ZERO() to  simplify the code Wei Yongjun <weiyj_lk@163.com> - 2016-07-06 15:30 +0200
      Re: [PATCH -next] memory: atmel-ebi: use PTR_ERR_OR_ZERO() to  simplify the code Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-07-06 15:40 +0200
  [PATCH -next v2] memory: atmel-ebi: use PTR_ERR_OR_ZERO() to simplify the code weiyj_lk@163.com - 2016-07-07 04:10 +0200

csiph-web