Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1437653
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Jiri Olsa <jolsa@redhat.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v13 5/8] perf record: Read from overwritable ring buffer |
| Date | Wed, 06 Jul 2016 13:40:02 +0200 |
| Message-ID | <rRTlo-bj-45@gated-at.bofh.it> (permalink) |
| References | <rR5yh-2a2-3@gated-at.bofh.it> <rR5yh-2a2-9@gated-at.bofh.it> |
| X-Original-To | Wang Nan <wangnan0@huawei.com> |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.6.1 (2016-04-27) |
| X-Scanned-By | MIMEDefang 2.68 on 10.5.11.22 |
| X-Greylist | Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 06 Jul 2016 11:39:01 +0000 (UTC) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 64 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | acme@kernel.org, linux-kernel@vger.kernel.org, pi3orama@163.com, lizefan@huawei.com, He Kuang <hekuang@huawei.com>, Arnaldo Carvalho de Melo <acme@redhat.com>, Jiri Olsa <jolsa@kernel.org>, Masami Hiramatsu <mhiramat@kernel.org>, Namhyung Kim <namhyung@kernel.org>, Nilay Vaish <nilayvaish@gmail.com> |
| X-Original-Date | Wed, 6 Jul 2016 13:38:57 +0200 |
| X-Original-Message-ID | <20160706113857.GD26517@krava> |
| X-Original-References | <1467613209-191781-1-git-send-email-wangnan0@huawei.com> <1467613209-191781-6-git-send-email-wangnan0@huawei.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1437653 |
Show key headers only | View raw
On Mon, Jul 04, 2016 at 06:20:06AM +0000, Wang Nan wrote:
SNIP
> +static void
> +record__toggle_overwrite_evsels(struct record *rec,
> + enum overwrite_evt_state state)
> +{
> + struct perf_evlist *evlist = rec->overwrite_evlist;
> + enum overwrite_evt_state old_state = rec->overwrite_evt_state;
> + enum action {
> + NONE,
> + PAUSE,
> + RESUME,
> + } action = NONE;
> +
> + switch (old_state) {
> + case OVERWRITE_EVT_RUNNING: {
> + switch (state) {
> + case OVERWRITE_EVT_DATA_PENDING:
> + action = PAUSE;
> + break;
> + case OVERWRITE_EVT_RUNNING:
> + case OVERWRITE_EVT_EMPTY:
> + default:
> + goto state_err;
> + }
> + break;
> + }
> + case OVERWRITE_EVT_DATA_PENDING: {
> + switch (state) {
> + case OVERWRITE_EVT_EMPTY:
> + break;
> + case OVERWRITE_EVT_RUNNING:
> + case OVERWRITE_EVT_DATA_PENDING:
> + default:
> + goto state_err;
> + }
> + break;
> + }
> + case OVERWRITE_EVT_EMPTY: {
> + switch (state) {
> + case OVERWRITE_EVT_RUNNING:
> + action = RESUME;
> + break;
> + case OVERWRITE_EVT_EMPTY:
> + case OVERWRITE_EVT_DATA_PENDING:
> + default:
> + goto state_err;
> + }
> + break;
> + }
> + default:
> + WARN_ONCE(1, "Shouldn't get there\n");
> + }
> +
> + rec->overwrite_evt_state = state;
> +
> + if (!evlist)
> + return;
I'd expect this check at the begining
jirka
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v13 5/8] perf record: Read from overwritable ring buffer Wang Nan <wangnan0@huawei.com> - 2016-07-04 08:30 +0200
Re: [PATCH v13 5/8] perf record: Read from overwritable ring buffer Jiri Olsa <jolsa@redhat.com> - 2016-07-06 13:40 +0200
Re: [PATCH v13 5/8] perf record: Read from overwritable ring buffer Jiri Olsa <jolsa@redhat.com> - 2016-07-06 13:40 +0200
Re: [PATCH v13 5/8] perf record: Read from overwritable ring buffer "Wangnan (F)" <wangnan0@huawei.com> - 2016-07-06 14:10 +0200
Re: [PATCH v13 5/8] perf record: Read from overwritable ring buffer Jiri Olsa <jolsa@redhat.com> - 2016-07-06 14:40 +0200
Re: [PATCH v13 5/8] perf record: Read from overwritable ring buffer "Wangnan (F)" <wangnan0@huawei.com> - 2016-07-07 07:10 +0200
csiph-web