Re: [PATCH v2] netfilter: nf_log: fix error on write NONE to logger choice sysctl

From	Pablo Neira Ayuso <pablo@netfilter.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] netfilter: nf_log: fix error on write NONE to logger choice sysctl
Date	2016-07-06 11:30 +0200
Message-ID	<rRRjz-7oL-1@gated-at.bofh.it> (permalink)
References	<rQ6Zs-7ge-17@gated-at.bofh.it> <rQ798-7jz-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jul 01, 2016 at 04:53:54PM +0300, Pavel Tikhomirov wrote:
> It is hard to unbind nf-logger:
> 
>   echo NONE > /proc/sys/net/netfilter/nf_log/0
>   bash: echo: write error: No such file or directory
> 
>   sysctl -w net.netfilter.nf_log.0=NONE
>   sysctl: setting key "net.netfilter.nf_log.0": No such file or directory
>   net.netfilter.nf_log.0 = NONE
> 
> You need explicitly send '\0', for instance like:
> 
>   echo -e "NONE\0" > /proc/sys/net/netfilter/nf_log/0
> 
> That seem to be strange, so fix it using proc_dostring.
> 
> Now it works fine:
>    modprobe nfnetlink_log
>    echo nfnetlink_log > /proc/sys/net/netfilter/nf_log/0
>    cat /proc/sys/net/netfilter/nf_log/0
>    nfnetlink_log
>    echo NONE > /proc/sys/net/netfilter/nf_log/0
>    cat /proc/sys/net/netfilter/nf_log/0
>    NONE

Applied, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] netfilter: nf_log: fix error on write NONE to logger choice sysctl Pavel Tikhomirov <ptikhomirov@virtuozzo.com> - 2016-07-01 15:50 +0200
  [PATCH v2] netfilter: nf_log: fix error on write NONE to logger choice sysctl Pavel Tikhomirov <ptikhomirov@virtuozzo.com> - 2016-07-01 16:00 +0200
    Re: [PATCH v2] netfilter: nf_log: fix error on write NONE to logger  choice sysctl Pablo Neira Ayuso <pablo@netfilter.org> - 2016-07-06 11:30 +0200

csiph-web