Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1437614

Re: [PATCH v4] gpio: add Intel WhiskeyCove GPIO driver

Show all headers | View raw

On Wed, Jul 06, 2016 at 10:57:19AM +0200, Linus Walleij wrote:
> On Tue, Jun 28, 2016 at 1:56 AM, Bin Gao <bin.gao@linux.intel.com> wrote:
> 
> > This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC.
> > This driver is based on gpio-crystalcove.c.
> >
> > Signed-off-by: Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>
> > Signed-off-by: Bin Gao <bin.gao@intel.com>
> > ---
> > Changes in v4:
> >  - Converted CTLI_INTCNT_XX macros to less verbose ones INT_DETECT_XX.
> >  - Add comments about why there is no .pm for the driver.
> >  - Header files re-ordered.
> >  - Various coding style change to address Andy's comments.
> 
> Mika can I have your ACK/review tag on this driver so I can merge it?
> I prefer to have all Intel stuff bearing your seal of approval.

Thanks for your trust :)

I don't have much comments in addition to what you already pointed out.
I'll just wait for the next revision and give my ack then.

> > +static irqreturn_t wcove_gpio_irq_handler(int irq, void *data)
> > +{
> > +       int pending;
> > +       unsigned int p0, p1, virq, gpio;
> > +       struct wcove_gpio *wg = data;

Bin,

Since you are going to make another iteration, please arrange the
declarations like:

	unsigned int p0, p1, virq, gpio;
	struct wcove_gpio *wg = data;
	int pending;

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4] gpio: add Intel WhiskeyCove GPIO driver Bin Gao <bin.gao@linux.intel.com> - 2016-06-28 02:00 +0200
  Re: [PATCH v4] gpio: add Intel WhiskeyCove GPIO driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-07-01 22:30 +0200
  Re: [PATCH v4] gpio: add Intel WhiskeyCove GPIO driver Linus Walleij <linus.walleij@linaro.org> - 2016-07-06 11:00 +0200
    Re: [PATCH v4] gpio: add Intel WhiskeyCove GPIO driver Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-07-06 12:10 +0200
      Re: [PATCH v4] gpio: add Intel WhiskeyCove GPIO driver Bin Gao <bin.gao@linux.intel.com> - 2016-07-07 07:30 +0200
    Re: [PATCH v4] gpio: add Intel WhiskeyCove GPIO driver Bin Gao <bin.gao@linux.intel.com> - 2016-07-07 07:30 +0200

csiph-web