Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1437324

Re: [PATCH v3 2/2] sound: lpass-platform: Move dma channel allocation to pcmops

Show all headers | View raw

On Mon, Jul 04, 2016 at 10:21:49AM +0100, Srinivas Kandagatla wrote:
> Move dma channel allocations to pcmops open and close functions. Reason
> to do this is that, lpass_platform_pcm_free() accesses snd_soc_pcm_runtime
> via substream->private data, However By this time runtimes are already
> freed as part of soc_cleanup_card_resources() sequence.
> 
> This patch moves the channel allocations/deallocations to pcmops open()
> and close() respectively, where the code has valid snd_soc_pcm_runtime.
> 
> Without this patch unloading lpass sound card module would result in below
> crash:

snip...

> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---

LGTM.

Acked-by: Kenneth Westfield <kwestfie@codeaurora.org>

-- 
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, 
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 2/2] sound: lpass-platform: Move dma channel allocation to pcmops Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-07-04 11:30 +0200
  Re: [PATCH v3 2/2] sound: lpass-platform: Move dma channel  allocation to pcmops Kenneth Westfield <kwestfie@codeaurora.org> - 2016-07-06 00:30 +0200

csiph-web