Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1437316

Re: [PATCH -v3 2/2] printk: Add kernel parameter to control writes to /dev/kmsg

Show all headers | View raw

On Tue, Jul 05, 2016 at 05:47:49PM -0400, Steven Rostedt wrote:
> I wonder if we should return some sort of error message here? ENODEV?

What for?

We're silently ignoring it. If we start returning an error here, we
might break doofus if it checks the write retval.

And it's not like we care - we're ignoring all writes whatsoever.

> If you silently fail here, then we lose all logging because systemd
> thinks this is working when it is not. That's not what I want.

Hmm, ok, you're making sense to me.

Do you want an error message too or only an -ENODEV returned or
somesuch?

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH -v3 2/2] printk: Add kernel parameter to control writes to /dev/kmsg Borislav Petkov <bp@alien8.de> - 2016-07-04 16:30 +0200
  Re: [PATCH -v3 2/2] printk: Add kernel parameter to control writes  to /dev/kmsg Steven Rostedt <rostedt@goodmis.org> - 2016-07-05 23:50 +0200
    Re: [PATCH -v3 2/2] printk: Add kernel parameter to control writes  to /dev/kmsg Borislav Petkov <bp@alien8.de> - 2016-07-06 00:10 +0200
      Re: [PATCH -v3 2/2] printk: Add kernel parameter to control writes  to /dev/kmsg Steven Rostedt <rostedt@goodmis.org> - 2016-07-06 00:10 +0200
  [PATCH -v3.1 2/2] printk: Add kernel parameter to control writes to  /dev/kmsg Borislav Petkov <bp@alien8.de> - 2016-07-06 15:30 +0200
    Re: [PATCH -v3.1 2/2] printk: Add kernel parameter to control  writes to /dev/kmsg Steven Rostedt <rostedt@goodmis.org> - 2016-07-06 20:00 +0200
      Re: [PATCH -v3.1 2/2] printk: Add kernel parameter to control writes  to /dev/kmsg Borislav Petkov <bp@alien8.de> - 2016-07-06 20:40 +0200

csiph-web